Apply code review comments

Fix some names and remove unnecessary code

Author: abonie

src/Compiler/FSComp.txt

@@ -1571,7 +1571,7 @@ featureWarningWhenCopyAndUpdateRecordChangesAllFields,"Raises warnings when an c
 featureStaticMembersInInterfaces,"Static members in interfaces"
 featureNonInlineLiteralsAsPrintfFormat,"String values marked as literals and IL constants as printf format"
 featureNestedCopyAndUpdate,"Nested record field copy-and-update"
-featureExtendedStringInterpolation,"Extended string interpolation similar to C# raw strings."
+featureExtendedStringInterpolation,"Extended string interpolation similar to C# raw string literals."
 3353,fsiInvalidDirective,"Invalid directive '#%s %s'"
 3354,tcNotAFunctionButIndexerNamedIndexingNotYetEnabled,"This value supports indexing, e.g. '%s.[index]'. The syntax '%s[index]' requires /langversion:preview. See https://aka.ms/fsharp-index-notation."
 3354,tcNotAFunctionButIndexerIndexingNotYetEnabled,"This expression supports indexing, e.g. 'expr.[index]'. The syntax 'expr[index]' requires /langversion:preview. See https://aka.ms/fsharp-index-notation."

src/Compiler/Service/FSharpCheckerResults.fs

@@ -2396,7 +2396,7 @@ module internal ParseAndCheckFile =
                     let braceOffset =
                         match tok with
                         | INTERP_STRING_BEGIN_PART (_, SynStringKind.TripleQuote, (LexerContinuation.Token (_, (_, _, dl, _) :: _))) ->
-                            max 0 (dl - 1)
+                            dl - 1
                         | _ -> 0
 
                     let m = lexbuf.LexemeRange

src/Compiler/Service/ServiceLexing.fs

@@ -513,7 +513,7 @@ module internal LexerStateEncoding =
     let ifdefstackNumBits = 24 // 0 means if, 1 means else
     let stringKindBits = 3
     let nestingBits = 12
-    let dlenBits = 3
+    let delimLenBits = 3
 
     let _ =
         assert
@@ -524,7 +524,7 @@ module internal LexerStateEncoding =
              + ifdefstackNumBits
              + stringKindBits
              + nestingBits
-             + dlenBits
+             + delimLenBits
              <= 64)
 
     let lexstateStart = 0
@@ -550,7 +550,7 @@ module internal LexerStateEncoding =
         + ifdefstackNumBits
         + stringKindBits
 
-    let dlenStart =
+    let delimLenStart =
         lexstateNumBits
         + ncommentsNumBits
         + hardwhiteNumBits
@@ -566,7 +566,7 @@ module internal LexerStateEncoding =
     let ifdefstackMask = Bits.mask64 ifdefstackStart ifdefstackNumBits
     let stringKindMask = Bits.mask64 stringKindStart stringKindBits
     let nestingMask = Bits.mask64 nestingStart nestingBits
-    let dlenMask = Bits.mask64 dlenStart dlenBits
+    let delimLenMask = Bits.mask64 delimLenStart delimLenBits
 
     let bitOfBool b = if b then 1 else 0
     let boolOfBit n = (n = 1L)
@@ -638,7 +638,7 @@ module internal LexerStateEncoding =
             ||| ((kind1 <<< 2) &&& 0b000000001100)
             ||| ((kind2 <<< 0) &&& 0b000000000011)
 
-        let delimLen = min delimLen (Bits.pown32 dlenBits)
+        let delimLen = min delimLen (Bits.pown32 delimLenBits)
 
         let bits =
             lexStateOfColorState colorState
@@ -648,7 +648,7 @@ module internal LexerStateEncoding =
             ||| ((int64 ifdefStackBits <<< ifdefstackStart) &&& ifdefstackMask)
             ||| ((int64 stringKindValue <<< stringKindStart) &&& stringKindMask)
             ||| ((int64 nestingValue <<< nestingStart) &&& nestingMask)
-            ||| ((int64 delimLen <<< dlenStart) &&& dlenMask)
+            ||| ((int64 delimLen <<< delimLenStart) &&& delimLenMask)
 
         {
             PosBits = b.Encoding
@@ -706,7 +706,7 @@ module internal LexerStateEncoding =
 
             nest
 
-        let delimLen = int32 ((bits &&& dlenMask) >>> dlenStart)
+        let delimLen = int32 ((bits &&& delimLenMask) >>> delimLenStart)
 
         (colorState, ncomments, pos, ifDefs, hardwhite, stringKind, stringNest, delimLen)
 

src/Compiler/lex.fsl

@@ -1642,7 +1642,7 @@ and extendedInterpolatedString sargs skip = parse
       if args.interpolationDelimiterLength > numBraces then
           lexeme lexbuf |> addUnicodeString buf
           (result())
-      else // numBraces >= args.interpolationDelimiterLength
+      else
           fail args lexbuf (FSComp.SR.lexUnmatchedRBracesInTripleQuote()) (result())
     }
 

src/Compiler/xlf/FSComp.txt.cs.xlf

@@ -253,8 +253,8 @@
         <note />
       </trans-unit>
       <trans-unit id="featureExtendedStringInterpolation">
-        <source>Extended string interpolation similar to C# raw strings.</source>
-        <target state="new">Extended string interpolation similar to C# raw strings.</target>
+        <source>Extended string interpolation similar to C# raw string literals.</source>
+        <target state="new">Extended string interpolation similar to C# raw string literals.</target>
         <note />
       </trans-unit>
       <trans-unit id="featureFixedIndexSlice3d4d">

src/Compiler/xlf/FSComp.txt.de.xlf

@@ -253,8 +253,8 @@
         <note />
       </trans-unit>
       <trans-unit id="featureExtendedStringInterpolation">
-        <source>Extended string interpolation similar to C# raw strings.</source>
-        <target state="new">Extended string interpolation similar to C# raw strings.</target>
+        <source>Extended string interpolation similar to C# raw string literals.</source>
+        <target state="new">Extended string interpolation similar to C# raw string literals.</target>
         <note />
       </trans-unit>
       <trans-unit id="featureFixedIndexSlice3d4d">

src/Compiler/xlf/FSComp.txt.es.xlf

@@ -253,8 +253,8 @@
         <note />
       </trans-unit>
       <trans-unit id="featureExtendedStringInterpolation">
-        <source>Extended string interpolation similar to C# raw strings.</source>
-        <target state="new">Extended string interpolation similar to C# raw strings.</target>
+        <source>Extended string interpolation similar to C# raw string literals.</source>
+        <target state="new">Extended string interpolation similar to C# raw string literals.</target>
         <note />
       </trans-unit>
       <trans-unit id="featureFixedIndexSlice3d4d">

src/Compiler/xlf/FSComp.txt.fr.xlf

@@ -253,8 +253,8 @@
         <note />
       </trans-unit>
       <trans-unit id="featureExtendedStringInterpolation">
-        <source>Extended string interpolation similar to C# raw strings.</source>
-        <target state="new">Extended string interpolation similar to C# raw strings.</target>
+        <source>Extended string interpolation similar to C# raw string literals.</source>
+        <target state="new">Extended string interpolation similar to C# raw string literals.</target>
         <note />
       </trans-unit>
       <trans-unit id="featureFixedIndexSlice3d4d">

src/Compiler/xlf/FSComp.txt.it.xlf

@@ -253,8 +253,8 @@
         <note />
       </trans-unit>
       <trans-unit id="featureExtendedStringInterpolation">
-        <source>Extended string interpolation similar to C# raw strings.</source>
-        <target state="new">Extended string interpolation similar to C# raw strings.</target>
+        <source>Extended string interpolation similar to C# raw string literals.</source>
+        <target state="new">Extended string interpolation similar to C# raw string literals.</target>
         <note />
       </trans-unit>
       <trans-unit id="featureFixedIndexSlice3d4d">

src/Compiler/xlf/FSComp.txt.ja.xlf

@@ -253,8 +253,8 @@
         <note />
       </trans-unit>
       <trans-unit id="featureExtendedStringInterpolation">
-        <source>Extended string interpolation similar to C# raw strings.</source>
-        <target state="new">Extended string interpolation similar to C# raw strings.</target>
+        <source>Extended string interpolation similar to C# raw string literals.</source>
+        <target state="new">Extended string interpolation similar to C# raw string literals.</target>
         <note />
       </trans-unit>
       <trans-unit id="featureFixedIndexSlice3d4d">