Moving AccessOfTypeAbbreviationTests over to NUnit (#7226)

* Moving AccessOfTypeAbbreviationTests over to NUnit

* ha! now I know what this `1` means =)

* Error range updated and removed `exit 0`

* Error message prefixed by "This construct is deprecated."

* Error messages changed based on current state of FSI

Author: sergey-tihon

tests/fsharp/Compiler/ErrorMessages/AccessOfTypeAbbreviationTests.fs

@@ -0,0 +1,75 @@
+// Copyright (c) Microsoft Corporation.  All Rights Reserved.  See License.txt in the project root for license information.
+
+namespace FSharp.Compiler.UnitTests
+
+open NUnit.Framework
+open FSharp.Compiler.SourceCodeServices
+
+[<TestFixture>]
+module ``Access Of Type Abbreviation`` =
+
+    [<Test>]
+    let ``Test1``() =
+        CompilerAssert.TypeCheckSingleError
+            """
+module Library =
+  type private Hidden = Hidden of unit
+  type Exported = Hidden
+            """
+            FSharpErrorSeverity.Warning
+            44
+            (4, 8, 4, 16)
+            "This construct is deprecated. The type 'Hidden' is less accessible than the value, member or type 'Exported' it is used in.\r\nAs of F# 4.1, the accessibility of type abbreviations is checked at compile-time. Consider changing the accessibility of the type abbreviation. Ignoring this warning might lead to runtime errors."
+
+    [<Test>]
+    let ``Test2``() =
+        CompilerAssert.Pass
+            """
+module Library =
+  type internal Hidden = Hidden of unit
+  type internal Exported = Hidden
+            """
+
+    [<Test>]
+    let ``Test3``() =
+        CompilerAssert.TypeCheckSingleError
+            """
+module Library =
+  type internal Hidden = Hidden of unit
+  type Exported = Hidden
+            """
+            FSharpErrorSeverity.Warning
+            44
+            (4, 8, 4, 16)
+            "This construct is deprecated. The type 'Hidden' is less accessible than the value, member or type 'Exported' it is used in.\r\nAs of F# 4.1, the accessibility of type abbreviations is checked at compile-time. Consider changing the accessibility of the type abbreviation. Ignoring this warning might lead to runtime errors."
+
+    [<Test>]
+    let ``Test4``() =
+        CompilerAssert.TypeCheckSingleError
+            """
+module Library =
+  type private Hidden = Hidden of unit
+  type internal Exported = Hidden
+            """
+            FSharpErrorSeverity.Warning
+            44
+            (4, 17, 4, 25)
+            "This construct is deprecated. The type 'Hidden' is less accessible than the value, member or type 'Exported' it is used in.\r\nAs of F# 4.1, the accessibility of type abbreviations is checked at compile-time. Consider changing the accessibility of the type abbreviation. Ignoring this warning might lead to runtime errors."
+
+    [<Test>]
+    let ``Test5``() =
+        CompilerAssert.Pass
+            """
+module Library =
+  type private Hidden = Hidden of unit
+  type private Exported = Hidden
+            """
+
+    [<Test>]
+    let ``Test6``() =
+        CompilerAssert.Pass
+            """
+module Library =
+  type Hidden = Hidden of unit
+  type Exported = Hidden
+            """

tests/fsharp/FSharpSuite.Tests.fsproj

@@ -32,6 +32,7 @@
     <Compile Include="tests.fs" />
     <Compile Include="Compiler\ILChecker.fs" />
     <Compile Include="Compiler\CompilerAssert.fs" />
+    <Compile Include="Compiler\ErrorMessages\AccessOfTypeAbbreviationTests.fs" />
     <Compile Include="Compiler\ErrorMessages\ElseBranchHasWrongTypeTests.fs" />
     <Compile Include="Compiler\ErrorMessages\MissingElseBranch.fs" />
     <Compile Include="Compiler\SourceTextTests.fs" />

tests/fsharpqa/Source/Warnings/AccessOfTypeAbbreviation.fs

@@ -13,12 +13,6 @@
 	SOURCE=WrongArity.fs # WrongArity.fs
 	SOURCE=OverrideErrors.fs # OverrideErrors.fs
 	SOURCE=MethodIsNotStatic.fs # MethodIsNotStatic.fs
-	SOURCE=AccessOfTypeAbbreviation.fs # AccessOfTypeAbbreviation.fs
-	SOURCE=AccessOfTypeAbbreviation2.fs # AccessOfTypeAbbreviation2.fs
-	SOURCE=AccessOfTypeAbbreviation3.fs # AccessOfTypeAbbreviation3.fs
-	SOURCE=AccessOfTypeAbbreviation4.fs # AccessOfTypeAbbreviation4.fs
-	SOURCE=AccessOfTypeAbbreviation5.fs # AccessOfTypeAbbreviation5.fs
-	SOURCE=AccessOfTypeAbbreviation6.fs # AccessOfTypeAbbreviation6.fs
 	SOURCE=EqualsInsteadOfInInForLoop.fs # EqualsInsteadOfInInForLoop.fs
 	SOURCE=DontWarnExternalFunctionAsUnused.fs SCFLAGS="--warnon:1182 --warnaserror+" # DontWarnExternalFunctionAsUnused.fs
 	SOURCE=SuggestTypesInModule.fs # SuggestTypesInModule.fs