Skip to content

System.String F# snippets #7875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 28, 2022
Merged

System.String F# snippets #7875

merged 3 commits into from
Mar 28, 2022

Conversation

@albert-du
Copy link
Contributor

@albert-du albert-du commented Mar 25, 2022

Adds F# snippets for String

@albert-du albert-du requested a review from a team as a code owner March 25, 2022 02:27
@ghost
Copy link

ghost commented Mar 25, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@albert-du albert-du mentioned this pull request Mar 25, 2022
Closed
@opbld33
Copy link

opbld33 commented Mar 25, 2022

Docs Build status updates of commit 2fa82b1:

✅ Validation status: passed

File Status Preview URL Details
snippets/fsharp/System/FormatException/Overview/FormatExample2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/format4.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/format5.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/format7.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/format_paramarray1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/formatexample4.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/formatoverload1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/formatoverload2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/formatsyntax1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/fs.fsproj ✅Succeeded
snippets/fsharp/System/FormatException/Overview/interceptor2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa-interpolated1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa-interpolated2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa11.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa21.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa26.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa27.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa28.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa29.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/starting1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/starting2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/starting3.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/char2_ctor.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/chptrctor_null.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/ctor1.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/ctor2.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/fs.fsproj ✅Succeeded
snippets/fsharp/System/String/.ctor/ptrctor_null.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/source.fs ✅Succeeded View
snippets/fsharp/System/String/Chars/chars1.fs ✅Succeeded View
snippets/fsharp/System/String/Chars/fs.fsproj ✅Succeeded
snippets/fsharp/System/String/Chars/uri_ishexdigit.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/ArrayListSample.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/Example.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/Example1.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/cmpcmp.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/comp3.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/comp4.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/comp5.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/compare02.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/compare21.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/compare22.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/compare23.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/fs.fsproj ✅Succeeded
snippets/fsharp/System/String/Compare/remarks.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/string.comp4.fs ✅Succeeded View
snippets/fsharp/System/String/CompareOrdinal/comp0.fs ✅Succeeded View
snippets/fsharp/System/String/CompareOrdinal/fs.fsproj ✅Succeeded
snippets/fsharp/System/String/CompareOrdinal/stringcompareordinal.fs ✅Succeeded View
snippets/fsharp/System/String/CompareTo/compareto1.fs ✅Succeeded View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Mar 25, 2022

Docs Build status updates of commit 72934a6:

✅ Validation status: passed

File Status Preview URL Details
snippets/fsharp/System/FormatException/Overview/FormatExample2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/format4.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/format5.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/format7.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/format_paramarray1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/formatexample4.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/formatoverload1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/formatoverload2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/formatsyntax1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/fs.fsproj ✅Succeeded
snippets/fsharp/System/FormatException/Overview/interceptor2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa-interpolated1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa-interpolated2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa11.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa21.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa26.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa27.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa28.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa29.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/starting1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/starting2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/starting3.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/char2_ctor.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/chptrctor_null.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/ctor1.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/ctor2.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/fs.fsproj ✅Succeeded
snippets/fsharp/System/String/.ctor/ptrctor_null.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/source.fs ✅Succeeded View
snippets/fsharp/System/String/Chars/chars1.fs ✅Succeeded View
snippets/fsharp/System/String/Chars/fs.fsproj ✅Succeeded
snippets/fsharp/System/String/Chars/uri_ishexdigit.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/ArrayListSample.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/Example.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/Example1.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/cmpcmp.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/comp3.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/comp4.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/comp5.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/compare02.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/compare21.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/compare22.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/compare23.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/fs.fsproj ✅Succeeded
snippets/fsharp/System/String/Compare/remarks.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/string.comp4.fs ✅Succeeded View
snippets/fsharp/System/String/CompareOrdinal/comp0.fs ✅Succeeded View
snippets/fsharp/System/String/CompareOrdinal/fs.fsproj ✅Succeeded
snippets/fsharp/System/String/CompareOrdinal/stringcompareordinal.fs ✅Succeeded View
snippets/fsharp/System/String/CompareTo/compareto1.fs ✅Succeeded View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld30
Copy link

opbld30 commented Mar 25, 2022

Docs Build status updates of commit b222677:

✅ Validation status: passed

File Status Preview URL Details
xml/System/StringSplitOptions.xml 💡Suggestion View Details
snippets/fsharp/System/FormatException/Overview/FormatExample2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/format4.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/format5.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/format7.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/format_paramarray1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/formatexample4.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/formatoverload1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/formatoverload2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/formatsyntax1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/fs.fsproj ✅Succeeded
snippets/fsharp/System/FormatException/Overview/interceptor2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa-interpolated1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa-interpolated2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa11.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa21.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa26.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa27.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa28.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/qa29.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/starting1.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/starting2.fs ✅Succeeded View
snippets/fsharp/System/FormatException/Overview/starting3.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/char2_ctor.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/chptrctor_null.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/ctor1.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/ctor2.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/fs.fsproj ✅Succeeded
snippets/fsharp/System/String/.ctor/ptrctor_null.fs ✅Succeeded View
snippets/fsharp/System/String/.ctor/source.fs ✅Succeeded View
snippets/fsharp/System/String/Chars/chars1.fs ✅Succeeded View
snippets/fsharp/System/String/Chars/fs.fsproj ✅Succeeded
snippets/fsharp/System/String/Chars/uri_ishexdigit.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/ArrayListSample.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/Example.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/Example1.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/cmpcmp.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/comp3.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/comp4.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/comp5.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/compare02.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/compare21.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/compare22.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/compare23.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/fs.fsproj ✅Succeeded
snippets/fsharp/System/String/Compare/remarks.fs ✅Succeeded View
snippets/fsharp/System/String/Compare/string.comp4.fs ✅Succeeded View
snippets/fsharp/System/String/CompareOrdinal/comp0.fs ✅Succeeded View
snippets/fsharp/System/String/CompareOrdinal/fs.fsproj ✅Succeeded
snippets/fsharp/System/String/CompareOrdinal/stringcompareordinal.fs ✅Succeeded View

This comment lists only the first 50 files in the pull request.

xml/System/StringSplitOptions.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

BillWagner
BillWagner approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @albert-du This took a while to review 😓 , but it's all good.

I'll :shipit: now.

@BillWagner BillWagner merged commit 4377a13 into dotnet:main Mar 28, 2022
@albert-du albert-du deleted the system-string-fsharp-snippets branch April 3, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@albert-du @opbld33 @opbld31 @opbld30 @BillWagner