Skip to content

Conversation

@gewarren
Copy link
Contributor

VSC-Service-Account and others added 2 commits March 24, 2022 05:17
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Runtime.InteropServices looks good

</AssemblyInfo>
<Attributes>
<Attribute FrameworkAlternate="dotnet-plat-ext-7.0">
<AttributeName Language="C#">[System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, "Failures")]</AttributeName>
Copy link
Contributor Author

@gewarren gewarren Mar 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@kouvel kouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System.Threading LGTM

@gewarren gewarren added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Mar 24, 2022
 Build.Reason:Manual by Genevieve Warren
 Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=284553&view=results
 source_repo.branch:net7-pre2
 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
@opbld32
Copy link

opbld32 commented Mar 25, 2022

Docs Build status updates of commit f2bf5fa:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Build.Construction/ProjectRootElement.xml ⚠️Warning View Details
xml/Microsoft.Build.Evaluation.Context/EvaluationContext.xml ⚠️Warning View Details
xml/Microsoft.Build.Evaluation/Project.xml ⚠️Warning View Details
xml/Microsoft.Build.Evaluation/ProjectCollection.xml ⚠️Warning View Details
xml/Microsoft.Build.Framework/BuildEventArgs.xml ⚠️Warning View Details
xml/Microsoft.Build.Tasks/Copy.xml ⚠️Warning View Details
xml/Microsoft.Build.Utilities/ToolLocationHelper.xml 💡Suggestion View Details
xml/Microsoft.Extensions.Logging/EventId.xml 💡Suggestion View Details
xml/Microsoft.Extensions.Primitives/StringSegment.xml 💡Suggestion View Details
xml/FrameworksIndex/dotnet-plat-ext-7.0.xml ✅Succeeded
xml/FrameworksIndex/net-7.0.xml ✅Succeeded
xml/FrameworksIndex/windowsdesktop-7.0.xml ✅Succeeded
xml/Microsoft.Build.Execution/BuildManager+DeferredBuildMessage.xml ✅Succeeded View
xml/Microsoft.Build.Experimental.ProjectCache/PluginTargetResult.xml ✅Succeeded View
xml/Microsoft.Build.Framework/SdkReference.xml ✅Succeeded View
xml/Microsoft.Build.Framework/SdkResolver.xml ✅Succeeded View
xml/Microsoft.Build.Framework/SdkResolverContext.xml ✅Succeeded View
xml/Microsoft.Build.Framework/SdkResult.xml ✅Succeeded View
xml/Microsoft.Build.Graph/ProjectGraph+GraphConstructionMetrics.xml ✅Succeeded View
xml/Microsoft.Build.Graph/ProjectGraph.xml ✅Succeeded View
xml/Microsoft.Build.Logging/BinaryLogger.xml ✅Succeeded View
xml/Microsoft.Build.Logging/BuildEventArgsReader.xml ✅Succeeded View
xml/Microsoft.Build.Logging/ProfilerLogger.xml ✅Succeeded View
xml/Microsoft.Build.Tasks/CodeTaskFactory.xml ✅Succeeded View
xml/Microsoft.Build.Tasks/DownloadFile.xml ✅Succeeded View
xml/Microsoft.Build.Tasks/Hash.xml ✅Succeeded View
xml/Microsoft.Build.Tasks/Unzip.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Distributed/DistributedCacheExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Distributed/IDistributedCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Distributed/MemoryDistributedCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/CacheEntryExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/CacheExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/ICacheEntry.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/IMemoryCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/MemoryCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/MemoryCacheEntryExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/MemoryCacheOptions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/PostEvictionCallbackRegistration.xml ✅Succeeded View
xml/Microsoft.Extensions.Configuration/ConfigurationRootExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/OptionsConfigurationServiceCollectionExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/OptionsServiceCollectionExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/ServiceProvider.xml ✅Succeeded View
xml/Microsoft.Extensions.FileProviders/CompositeFileProvider.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigurationChangeTokenSource`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigureNamedOptions`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigureNamedOptions`2.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigureNamedOptions`3.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigureNamedOptions`4.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigureNamedOptions`5.xml ✅Succeeded View

This comment lists only the first 50 files in the pull request.

xml/Microsoft.Build.Construction/ProjectRootElement.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Build.Construction.ProjectRootElement.MarkDirty(System.String,System.String)'.

xml/Microsoft.Build.Evaluation.Context/EvaluationContext.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Build.Shared.FileSystem.IFileSystem'.

xml/Microsoft.Build.Evaluation/Project.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Build.Evaluation.ProjectItem.ChangeItemType(System.String)'.
  • Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'seealso' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/Microsoft.Build.Evaluation/ProjectCollection.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Build.Evaluation.ProjectCollection.ToolsetsVersion'.

xml/Microsoft.Build.Framework/BuildEventArgs.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Build.Framework.BuildEventArgs.timestamp'.

xml/Microsoft.Build.Tasks/Copy.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'Microsoft.Build.Tasks.Copy.RetryDelayMillisecondsDefault'.

xml/Microsoft.Build.Utilities/ToolLocationHelper.xml

  • Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'param' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/Microsoft.Extensions.Logging/EventId.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Equals(System.Object) for uid: Microsoft.Extensions.Logging.EventId.Equals(System.Object).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:GetHashCode for uid: Microsoft.Extensions.Logging.EventId.GetHashCode.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs] Inheridoc tag exists but no inheritdoc found for uid:Microsoft.Extensions.Logging.EventId.GetHashCode.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:ToString for uid: Microsoft.Extensions.Logging.EventId.ToString.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs] Inheridoc tag exists but no inheritdoc found for uid:Microsoft.Extensions.Logging.EventId.ToString.

xml/Microsoft.Extensions.Primitives/StringSegment.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Equals(System.Object) for uid: Microsoft.Extensions.Primitives.StringSegment.Equals(System.Object).

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren
Copy link
Contributor Author

Going to start from scratch.

@gewarren gewarren closed this Mar 25, 2022
@opbld33
Copy link

opbld33 commented Mar 25, 2022

Docs Build status updates of commit e206de8:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Logging/EventId.xml 💡Suggestion View Details
xml/Microsoft.Extensions.Primitives/StringSegment.xml 💡Suggestion View Details
xml/FrameworksIndex/dotnet-plat-ext-7.0.xml ✅Succeeded
xml/FrameworksIndex/net-7.0.xml ✅Succeeded
xml/FrameworksIndex/windowsdesktop-7.0.xml ✅Succeeded
xml/Microsoft.Build.Framework.XamlTypes/BaseProperty.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Distributed/DistributedCacheExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Distributed/IDistributedCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Distributed/MemoryDistributedCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/CacheEntryExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/CacheExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/ICacheEntry.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/IMemoryCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/MemoryCache.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/MemoryCacheEntryExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/MemoryCacheOptions.xml ✅Succeeded View
xml/Microsoft.Extensions.Caching.Memory/PostEvictionCallbackRegistration.xml ✅Succeeded View
xml/Microsoft.Extensions.Configuration/ConfigurationRootExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderConfigurationExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/OptionsConfigurationServiceCollectionExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/OptionsServiceCollectionExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/ServiceProvider.xml ✅Succeeded View
xml/Microsoft.Extensions.FileProviders/CompositeFileProvider.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigurationChangeTokenSource`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigureNamedOptions`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigureNamedOptions`2.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigureNamedOptions`3.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigureNamedOptions`4.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigureNamedOptions`5.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigureNamedOptions`6.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/ConfigureOptions`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/DataAnnotationValidateOptions`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IConfigureNamedOptions`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsChangeTokenSource`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsMonitorCache`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsMonitor`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsSnapshot`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IPostConfigureOptions`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IValidateOptions`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/NamedConfigureFromConfigurationOptions`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsBuilder`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsCache`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsManager`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsMonitorExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsMonitor`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsValidationException.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/PostConfigureOptions`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/PostConfigureOptions`2.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/PostConfigureOptions`3.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/PostConfigureOptions`4.xml ✅Succeeded View

This comment lists only the first 50 files in the pull request.

xml/Microsoft.Extensions.Logging/EventId.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Equals(System.Object) for uid: Microsoft.Extensions.Logging.EventId.Equals(System.Object).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:GetHashCode for uid: Microsoft.Extensions.Logging.EventId.GetHashCode.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs] Inheridoc tag exists but no inheritdoc found for uid:Microsoft.Extensions.Logging.EventId.GetHashCode.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:ToString for uid: Microsoft.Extensions.Logging.EventId.ToString.
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundDocs] Inheridoc tag exists but no inheritdoc found for uid:Microsoft.Extensions.Logging.EventId.ToString.

xml/Microsoft.Extensions.Primitives/StringSegment.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NoFoundParent] Found no member can be inherited by key:Equals(System.Object) for uid: Microsoft.Extensions.Primitives.StringSegment.Equals(System.Object).

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren deleted the net7-preview2 branch March 25, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants