-
Notifications
You must be signed in to change notification settings - Fork 1.6k
CI update - .NET 7 Preview 2 #7871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=284382&view=results source_repo.branch:net7-pre2 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
jkoritzinsky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System.Runtime.InteropServices looks good
| </AssemblyInfo> | ||
| <Attributes> | ||
| <Attribute FrameworkAlternate="dotnet-plat-ext-7.0"> | ||
| <AttributeName Language="C#">[System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, "Failures")]</AttributeName> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@huangmin-ms These attributes seem excessive - there are 3 for each annotated property. See https://github.com/dotnet/runtime/blob/c74a3fdf01d57a14218056475f952aae4b6f4e2e/src/libraries/Microsoft.Extensions.Options/src/ValidateOptionsResult.cs#L38-L40 for source code.
kouvel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System.Threading LGTM
xml/System.Security.Cryptography.X509Certificates/CertificateRequest.xml
Show resolved
Hide resolved
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=284553&view=results source_repo.branch:net7-pre2 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
|
Docs Build status updates of commit f2bf5fa:
|
|
Going to start from scratch. |
cc @carlossanlop