From 75e41ce9f07ea71507799e4dfefa9aaefc255e68 Mon Sep 17 00:00:00 2001 From: "Ryland 41491307+ryalanms@users.noreply.github.com" <41491307+ryalanms@users.noreply.github.com> Date: Thu, 15 Aug 2019 15:28:20 -0700 Subject: [PATCH 1/5] Add documentation for WPF's System.Windows.Media.PenDashCap enum and System.Windows.Media.IAnimation interface --- xml/System.Windows.Media.Animation/IAnimation.xml | 13 +++++++------ xml/System.Windows.Media/PenDashCap.xml | 9 +++++---- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/xml/System.Windows.Media.Animation/IAnimation.xml b/xml/System.Windows.Media.Animation/IAnimation.xml index 68e5dc8d0a8..576f13d9d23 100644 --- a/xml/System.Windows.Media.Animation/IAnimation.xml +++ b/xml/System.Windows.Media.Animation/IAnimation.xml @@ -11,7 +11,7 @@ - To be added. + Interface to be implemented by an object that can animate a property value. To be added. @@ -35,13 +35,14 @@ - To be added. - To be added. - To be added. - To be added. - To be added. + This value is the suggested origin value provided to the animation to be used if the animation does not have its own concept of a start value. If this animation is the first in a composition chain this value will be the snapshot value if one is available or the base property value if it is not; otherise this value will be the value returned by the previous animation in the chain with an animationClock that is not Stopped. + This value is the suggested destination value provided to the animation to be used if the animation does not have its own concept of an end value. This value will be the base value if the animation is in the first composition layer of animations on a property; otherwise this value will be the output value from the previous composition layer of animations for the property. + This is the animationClock which can generate the CurrentTime or CurrentProgress value to be used by the animation to generate its output value. + Calculates the value this animation believes should be the current value for the property. + The value this animation believes should be the current value for the property. To be added. + diff --git a/xml/System.Windows.Media/PenDashCap.xml b/xml/System.Windows.Media/PenDashCap.xml index bb4486534d1..f8847896cf9 100644 --- a/xml/System.Windows.Media/PenDashCap.xml +++ b/xml/System.Windows.Media/PenDashCap.xml @@ -13,7 +13,7 @@ System.Enum - To be added. + Describes the shape at the ends of each dash segment. To be added. @@ -34,7 +34,7 @@ 0 - To be added. + A cap that does not extend past the last point of the line. Comparable to no line cap. @@ -54,7 +54,7 @@ 2 - To be added. + A semicircle that has a diameter equal to the line thickness. @@ -74,8 +74,9 @@ 3 - To be added. + An isosceles right triangle whose base length is equal to the thickness of the line. + From 63fb91da11f5ef17fc5e542b0f36bb6fb97eb6d0 Mon Sep 17 00:00:00 2001 From: Ron Petrusha Date: Thu, 15 Aug 2019 15:51:58 -0700 Subject: [PATCH 2/5] Minor change to PenDashCap enumeration --- xml/System.Windows.Media/PenDashCap.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Windows.Media/PenDashCap.xml b/xml/System.Windows.Media/PenDashCap.xml index f8847896cf9..07d01f741a6 100644 --- a/xml/System.Windows.Media/PenDashCap.xml +++ b/xml/System.Windows.Media/PenDashCap.xml @@ -13,7 +13,7 @@ System.Enum - Describes the shape at the ends of each dash segment. + Describes the shape at the end of each dash segment. To be added. @@ -34,7 +34,7 @@ 0 - A cap that does not extend past the last point of the line. Comparable to no line cap. + A cap that does not extend past the last point of the line. It is comparable to no line cap. From fc81db11b85072c2d9703053b051e711a2a3a849 Mon Sep 17 00:00:00 2001 From: Ron Petrusha Date: Thu, 15 Aug 2019 16:05:08 -0700 Subject: [PATCH 3/5] Edited. --- xml/System.Windows.Media.Animation/IAnimation.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xml/System.Windows.Media.Animation/IAnimation.xml b/xml/System.Windows.Media.Animation/IAnimation.xml index 576f13d9d23..2426cae2b80 100644 --- a/xml/System.Windows.Media.Animation/IAnimation.xml +++ b/xml/System.Windows.Media.Animation/IAnimation.xml @@ -11,7 +11,7 @@ - Interface to be implemented by an object that can animate a property value. + Provides support for animating a property value. To be added. @@ -35,9 +35,9 @@ - This value is the suggested origin value provided to the animation to be used if the animation does not have its own concept of a start value. If this animation is the first in a composition chain this value will be the snapshot value if one is available or the base property value if it is not; otherise this value will be the value returned by the previous animation in the chain with an animationClock that is not Stopped. - This value is the suggested destination value provided to the animation to be used if the animation does not have its own concept of an end value. This value will be the base value if the animation is in the first composition layer of animations on a property; otherwise this value will be the output value from the previous composition layer of animations for the property. - This is the animationClock which can generate the CurrentTime or CurrentProgress value to be used by the animation to generate its output value. + The suggested origin value to provide the animation, which is used if the animation does not have its own concept of a start value. If this animation is the first in a composition chain, it is the snapshot value, if one is available, or the base property value, if it is not; otherwise, it is the value returned by the previous animation in the chain with an animation clock that is not . + The suggested destination value to provide the animation, which is used if the animation does not have its own concept of an end value. It is the base value if the animation is in the first composition layer of animations on a property; otherwise, it is the output value from the previous composition layer of animations for the property. + The animation clock that can generate the or value to be used by the animation to generate its output value. Calculates the value this animation believes should be the current value for the property. The value this animation believes should be the current value for the property. To be added. From d0eec43b1ff6ff08d70029e50ca6671f2c4e7b27 Mon Sep 17 00:00:00 2001 From: "Ryland 41491307+ryalanms@users.noreply.github.com" <41491307+ryalanms@users.noreply.github.com> Date: Thu, 15 Aug 2019 16:24:52 -0700 Subject: [PATCH 4/5] PR feedback --- xml/System.Windows.Media.Animation/IAnimation.xml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/xml/System.Windows.Media.Animation/IAnimation.xml b/xml/System.Windows.Media.Animation/IAnimation.xml index 2426cae2b80..7b832679e8c 100644 --- a/xml/System.Windows.Media.Animation/IAnimation.xml +++ b/xml/System.Windows.Media.Animation/IAnimation.xml @@ -35,9 +35,9 @@ - The suggested origin value to provide the animation, which is used if the animation does not have its own concept of a start value. If this animation is the first in a composition chain, it is the snapshot value, if one is available, or the base property value, if it is not; otherwise, it is the value returned by the previous animation in the chain with an animation clock that is not . - The suggested destination value to provide the animation, which is used if the animation does not have its own concept of an end value. It is the base value if the animation is in the first composition layer of animations on a property; otherwise, it is the output value from the previous composition layer of animations for the property. - The animation clock that can generate the or value to be used by the animation to generate its output value. + The suggested origin value to provide the animation, which is used if the animation does not have its own concept of a start value. If this animation is the first in a composition chain, it is the snapshot value, if one is available, or the base property value, if it is not; otherwise, it is the value returned by the previous animation in the chain with an animation clock that is not . + The suggested destination value to provide the animation, which is used if the animation does not have its own concept of an end value. It is the base value if the animation is in the first composition layer of animations on a property; otherwise, it is the output value from the previous composition layer of animations for the property. + The animation clock that can generate the or value to be used by the animation to generate its output value. Calculates the value this animation believes should be the current value for the property. The value this animation believes should be the current value for the property. To be added. @@ -46,3 +46,4 @@ + From 69833b29a7a6979462c0288427f3d7e5bff0bca1 Mon Sep 17 00:00:00 2001 From: Maira Wenzel Date: Fri, 16 Aug 2019 00:50:30 -0700 Subject: [PATCH 5/5] fix broken links --- xml/System.Windows.Media.Animation/IAnimation.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Windows.Media.Animation/IAnimation.xml b/xml/System.Windows.Media.Animation/IAnimation.xml index 7b832679e8c..3567ded27bd 100644 --- a/xml/System.Windows.Media.Animation/IAnimation.xml +++ b/xml/System.Windows.Media.Animation/IAnimation.xml @@ -37,7 +37,7 @@ The suggested origin value to provide the animation, which is used if the animation does not have its own concept of a start value. If this animation is the first in a composition chain, it is the snapshot value, if one is available, or the base property value, if it is not; otherwise, it is the value returned by the previous animation in the chain with an animation clock that is not . The suggested destination value to provide the animation, which is used if the animation does not have its own concept of an end value. It is the base value if the animation is in the first composition layer of animations on a property; otherwise, it is the output value from the previous composition layer of animations for the property. - The animation clock that can generate the or value to be used by the animation to generate its output value. + The animation clock that can generate the or value to be used by the animation to generate its output value. Calculates the value this animation believes should be the current value for the property. The value this animation believes should be the current value for the property. To be added.