From c4f61ee31b5fa933abe7fcd68fc4d4421189ec54 Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Tue, 6 Aug 2019 11:47:25 -0700 Subject: [PATCH 1/6] Document System.Security.Cryptography.Pkcs.SignerInfo --- .../SignerInfo.xml | 21 +++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml b/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml index ef85c1b3d60..5113e41c364 100644 --- a/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml +++ b/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml @@ -59,9 +59,13 @@ - To be added. - To be added. + The attribute to add, an object with Abstract Syntax Notation One (ASN.1)-encoded data. + Adds the specified attribute to the current instance's attribute collection. If the attribute already exists, it gets merged with the specified attribute. The document gets re-encoded after the addition. To be added. + Cannot find the original signer. + -or- + +ASN1 corrupted data. @@ -593,9 +597,18 @@ - To be added. - To be added. + The attribute to remove, an object with Abstract Syntax Notation One (ASN.1)-encoded data. + Removes the specified attribute to the current instance's attribute collection. If the attribute does not exist, the method throws. The document gets re-encoded after the removal. To be added. + Cannot find the original signer. + + -or- + +Attribute not found. + + -or- + +ASN1 corrupted data. From 92f532716a8c63bf916678eb8e84438da152253d Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Tue, 6 Aug 2019 12:53:49 -0700 Subject: [PATCH 2/6] suggestions by rpetrusha Co-Authored-By: Ron Petrusha --- .../SignerInfo.xml | 24 +++++++++++++++---- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml b/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml index 5113e41c364..83a46db60e2 100644 --- a/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml +++ b/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml @@ -60,8 +60,16 @@ The attribute to add, an object with Abstract Syntax Notation One (ASN.1)-encoded data. - Adds the specified attribute to the current instance's attribute collection. If the attribute already exists, it gets merged with the specified attribute. The document gets re-encoded after the addition. - To be added. + Adds the specified attribute to the current instance's attribute collection. + + + Cannot find the original signer. -or- @@ -598,8 +606,14 @@ ASN1 corrupted data. The attribute to remove, an object with Abstract Syntax Notation One (ASN.1)-encoded data. - Removes the specified attribute to the current instance's attribute collection. If the attribute does not exist, the method throws. The document gets re-encoded after the removal. - To be added. + Removes the specified attribute to the current instance's attribute collection. + + + Cannot find the original signer. -or- @@ -823,4 +837,4 @@ ASN1 corrupted data. - \ No newline at end of file + From 977c4a4a1896aa8b67eb8803bb81d18af5cb3d04 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Tue, 6 Aug 2019 15:10:03 -0700 Subject: [PATCH 3/6] Update xml/System.Security.Cryptography.Pkcs/SignerInfo.xml Co-Authored-By: Ron Petrusha --- xml/System.Security.Cryptography.Pkcs/SignerInfo.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml b/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml index 83a46db60e2..1800e79312f 100644 --- a/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml +++ b/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml @@ -71,6 +71,7 @@ The document is re-encoded after the addition. ]]> Cannot find the original signer. + -or- ASN1 corrupted data. From 13def76e0f406bbee271aede262d30898a24b4fc Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Tue, 6 Aug 2019 15:22:18 -0700 Subject: [PATCH 4/6] suggestions by krwq --- xml/System.Security.Cryptography.Pkcs/SignerInfo.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml b/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml index 1800e79312f..e4cbfad8da6 100644 --- a/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml +++ b/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml @@ -59,8 +59,8 @@ - The attribute to add, an object with Abstract Syntax Notation One (ASN.1)-encoded data. - Adds the specified attribute to the current instance's attribute collection. + The ASN.1 encoded attribute to add to the document. + Adds the specified attribute to the current document. - The attribute to remove, an object with Abstract Syntax Notation One (ASN.1)-encoded data. + The ASN.1 encoded attribute to remove from the document. Removes the specified attribute to the current instance's attribute collection. Date: Tue, 6 Aug 2019 15:22:57 -0700 Subject: [PATCH 5/6] suggestion by krwq --- xml/System.Security.Cryptography.Pkcs/SignerInfo.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml b/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml index e4cbfad8da6..fe714a88d9d 100644 --- a/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml +++ b/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml @@ -607,7 +607,7 @@ ASN1 corrupted data. The ASN.1 encoded attribute to remove from the document. - Removes the specified attribute to the current instance's attribute collection. + Removes the specified attribute from the current document. Date: Tue, 6 Aug 2019 15:29:26 -0700 Subject: [PATCH 6/6] clarify merge --- xml/System.Security.Cryptography.Pkcs/SignerInfo.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml b/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml index fe714a88d9d..54af3df916c 100644 --- a/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml +++ b/xml/System.Security.Cryptography.Pkcs/SignerInfo.xml @@ -64,7 +64,7 @@