From 89636a149b1258f9f52b936a23199dc9e5ee23e0 Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Tue, 6 Aug 2019 11:07:23 -0700 Subject: [PATCH 1/7] Document System.Security.Cryptography.Pkcs.SubjectIdentifier.MatchesCertificate --- .../SubjectIdentifier.xml | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml index 439fafbf8e4..690d71c75c9 100644 --- a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml +++ b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml @@ -52,10 +52,21 @@ - To be added. - To be added. - To be added. - To be added. + The certificate to verify for a match. + Verifies if the specified certificate was used for the decryption operation. + if the certificate; otherwise. + + , this method compares the current instance's X09 issuer serial number and issuer name with the specified certificate's issuer serial number and issuer name. + +If the current subject identifier instance is of type , this method compares the current instance's subject key identifier with the specified certificate's subject key identifier. + + ]]> + + Invalid subject identifier type. From 2ef8b2b1d203f70d8fe5a6cae962c2fe4eca5f56 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Tue, 6 Aug 2019 12:05:54 -0700 Subject: [PATCH 2/7] suggestions by rpetrusha Co-Authored-By: Ron Petrusha --- xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml index 690d71c75c9..621df9982ca 100644 --- a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml +++ b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml @@ -54,7 +54,7 @@ The certificate to verify for a match. Verifies if the specified certificate was used for the decryption operation. - if the certificate; otherwise. + if the specified certificate was used for decryption; otherwise, . - \ No newline at end of file + From 0d4743f5f89743e3bb20e30d26942f293a671efa Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Tue, 6 Aug 2019 14:07:39 -0700 Subject: [PATCH 3/7] single paragraph --- xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml index 621df9982ca..4b38ea9995e 100644 --- a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml +++ b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml @@ -60,9 +60,7 @@ ## Remarks -If the current subject identifier instance is of type , this method compares the current instance's X09 issuer serial number and issuer name with the specified certificate's issuer serial number and issuer name. - -If the current subject identifier instance is of type , this method compares the current instance's subject key identifier with the specified certificate's subject key identifier. +If the current subject identifier instance is of type , this method compares the current instance's X09 issuer serial number and issuer name with the specified certificate's issuer serial number and issuer name. If the current subject identifier instance is of type , this method compares the current instance's subject key identifier with the specified certificate's subject key identifier. ]]> From a962c0ed8094fd2769306a37051b1633b825b0d0 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Tue, 6 Aug 2019 15:08:09 -0700 Subject: [PATCH 4/7] Update xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml --- xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml index 4b38ea9995e..d51ac64bf55 100644 --- a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml +++ b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml @@ -54,7 +54,7 @@ The certificate to verify for a match. Verifies if the specified certificate was used for the decryption operation. - if the specified certificate was used for decryption; otherwise, . + if the specified certificate's identifier matches the current subject identifier instance; otherwise, . Date: Tue, 6 Aug 2019 15:23:30 -0700 Subject: [PATCH 5/7] suggestion by krwq --- xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml index d51ac64bf55..2dc6731a1dd 100644 --- a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml +++ b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml @@ -52,7 +52,7 @@ - The certificate to verify for a match. + The certificate to match with the current subject identifier instance. Verifies if the specified certificate was used for the decryption operation. if the specified certificate's identifier matches the current subject identifier instance; otherwise, . From e968e33490912b58435a8c3e1ff854662ddb6cf9 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Tue, 6 Aug 2019 15:45:47 -0700 Subject: [PATCH 6/7] suggestion by krwq Co-Authored-By: Krzysztof Wicher --- xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml index 2dc6731a1dd..fa27703b3f0 100644 --- a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml +++ b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml @@ -53,7 +53,7 @@ The certificate to match with the current subject identifier instance. - Verifies if the specified certificate was used for the decryption operation. + Verifies if the specified certificate's subject identifier matches current subject identifier instance. if the specified certificate's identifier matches the current subject identifier instance; otherwise, . Date: Wed, 7 Aug 2019 11:15:43 -0700 Subject: [PATCH 7/7] Fixed broken xrefs --- xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml index fa27703b3f0..0b62b0d617e 100644 --- a/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml +++ b/xml/System.Security.Cryptography.Pkcs/SubjectIdentifier.xml @@ -60,7 +60,7 @@ ## Remarks -If the current subject identifier instance is of type , this method compares the current instance's X09 issuer serial number and issuer name with the specified certificate's issuer serial number and issuer name. If the current subject identifier instance is of type , this method compares the current instance's subject key identifier with the specified certificate's subject key identifier. +If the current subject identifier instance is of type , this method compares the current instance's X09 issuer serial number and issuer name with the specified certificate's issuer serial number and issuer name. If the current subject identifier instance is of type , this method compares the current instance's subject key identifier with the specified certificate's subject key identifier. ]]>