Skip to content

Document System.Security.Cryptography.Pkcs.SignedCms #2938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2019
Merged

Document System.Security.Cryptography.Pkcs.SignedCms #2938

merged 2 commits into from
Aug 6, 2019

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Aug 6, 2019

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 labels Aug 6, 2019
@carlossanlop carlossanlop added this to the August 2019 milestone Aug 6, 2019
@carlossanlop carlossanlop self-assigned this Aug 6, 2019
rpetrusha
rpetrusha suggested changes Aug 6, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left one comment and one suggestion, @carlossanlop.

@carlossanlop carlossanlop added changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review and removed waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Aug 6, 2019
@carlossanlop carlossanlop requested a review from rpetrusha August 6, 2019 19:00
@carlossanlop
Copy link
Contributor Author

carlossanlop commented Aug 6, 2019

Suggestions addresed, @rpetrusha, thank you for noticing.
@krwq can you please make sure the descriptions I added are accurate?

krwq
krwq approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM content-wise

@rpetrusha
Copy link

rpetrusha commented Aug 6, 2019

Is this ready to merge, @carlossanlop?

@rpetrusha
Copy link

rpetrusha commented Aug 6, 2019

Thanks, @krwq. I'll merge now, @carlossanlop.

@rpetrusha rpetrusha merged commit 7c7d533 into dotnet:master Aug 6, 2019
@carlossanlop carlossanlop deleted the SignedCms branch August 6, 2019 22:04
@mairaw mairaw removed the changes-addressed Indicates PRs that had all comments addressed and are awaiting for new review label Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krwq krwq krwq approved these changes

@GrabYourPitchforks GrabYourPitchforks Awaiting requested review from GrabYourPitchforks

@bartonjs bartonjs Awaiting requested review from bartonjs

@mairaw mairaw Awaiting requested review from mairaw

@jozkee jozkee Awaiting requested review from jozkee

+1 more reviewer

@rpetrusha rpetrusha rpetrusha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlossanlop carlossanlop

Labels

🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles

Projects

None yet

Milestone

August 2019

Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop @rpetrusha @krwq @mairaw