From c9a67ed3e5110d80c4175c443d48dca151311438 Mon Sep 17 00:00:00 2001
From: carlossanlop <calope@microsoft.com>
Date: Thu, 1 Aug 2019 14:05:20 -0700
Subject: [PATCH 1/3] Document various isolated System.Text.Json elements

---
 .../JsonStringEnumConverter.xml                      | 12 ++++++------
 xml/System.Text.Json/JsonElement.xml                 |  4 ++--
 xml/System.Text.Json/JsonEncodedText.xml             |  6 +++---
 3 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/xml/System.Text.Json.Serialization/JsonStringEnumConverter.xml b/xml/System.Text.Json.Serialization/JsonStringEnumConverter.xml
index 2924c7d4e47..32243373f31 100644
--- a/xml/System.Text.Json.Serialization/JsonStringEnumConverter.xml
+++ b/xml/System.Text.Json.Serialization/JsonStringEnumConverter.xml
@@ -84,9 +84,9 @@ Reading is case insensitive. Writing can be customized by using a <xref:System.T
         <Parameter Name="typeToConvert" Type="System.Type" />
       </Parameters>
       <Docs>
-        <param name="typeToConvert">To be added.</param>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
+        <param name="typeToConvert">The type is checked as to whether it can be converted.</param>
+        <summary>Determines whether the type can be converted.</summary>
+        <returns><see langword="true" /> if the type can be converted; <see langword="false" /> otherwise.</returns>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
@@ -109,9 +109,9 @@ Reading is case insensitive. Writing can be customized by using a <xref:System.T
         <Parameter Name="typeToConvert" Type="System.Type" />
       </Parameters>
       <Docs>
-        <param name="typeToConvert">To be added.</param>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
+        <param name="typeToConvert">The <see cref="T:System.Type"/> being converted.</param>
+        <summary>Create a converter for the provided <see cref="T:System.Type"/>.</summary>
+        <returns>An instance of <see cref="T:System.Text.Json.Serialization.JsonConverter"/> of type T, where T is compatible with <paramref name="typeToConvert"/>.</returns>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
diff --git a/xml/System.Text.Json/JsonElement.xml b/xml/System.Text.Json/JsonElement.xml
index d9bf2bb8c0c..e657abd8f68 100644
--- a/xml/System.Text.Json/JsonElement.xml
+++ b/xml/System.Text.Json/JsonElement.xml
@@ -837,9 +837,9 @@ This method does not parse the contents of a JSON string value.
         <Parameter Name="index" Type="System.Int32" />
       </Parameters>
       <Docs>
-        <param name="index">To be added.</param>
+        <param name="index">The item index.</param>
         <summary>Gets the value at a specified index when the current value is an <see cref="F:System.Text.Json.JsonValueKind.Array" />.</summary>
-        <value>To be added.</value>
+        <value>A <see cref="T:System.Text.Json.JsonElement" /> located in the <paramref name="index" /> position.</value>
         <remarks>To be added.</remarks>
         <exception cref="T:System.InvalidOperationException">This value's <see cref="P:System.Text.Json.JsonElement.ValueKind" /> is not <see cref="F:System.Text.Json.JsonValueKind.Array" />.</exception>
         <exception cref="T:System.IndexOutOfRangeException"><paramref name="index" /> is not in the range [0, <see cref="M:System.Text.Json.JsonElement.GetArrayLength" />()).</exception>
diff --git a/xml/System.Text.Json/JsonEncodedText.xml b/xml/System.Text.Json/JsonEncodedText.xml
index b76c17a5450..83d45f3e2e6 100644
--- a/xml/System.Text.Json/JsonEncodedText.xml
+++ b/xml/System.Text.Json/JsonEncodedText.xml
@@ -108,7 +108,7 @@ This type can be used to cache and store known strings used for writing JSON ahe
       <Docs>
         <param name="value">The value to be transformed as JSON encoded text.</param>
         <summary>Encodes the string text value as a JSON string.</summary>
-        <returns>To be added.</returns>
+        <returns>The string encoded as a JSON string.</returns>
         <remarks>To be added.</remarks>
         <exception cref="T:System.ArgumentNullException"><paramref name="value" /> is <see langword="null" />.</exception>
         <exception cref="T:System.ArgumentException"><paramref name="value" /> is too large or contains invalid UTF-16 characters.</exception>
@@ -154,7 +154,7 @@ This type can be used to cache and store known strings used for writing JSON ahe
         <Parameter Name="obj" Type="System.Object" />
       </Parameters>
       <Docs>
-        <param name="obj">To be added.</param>
+        <param name="obj">The object to compare to this instance.</param>
         <summary>Determines whether this instance and a specified object, which must also be a <see cref="T:System.Text.Json.JsonEncodedText" /> instance, have the same value.</summary>
         <returns><see langword="true" /> if the current instance and <paramref name="obj" /> are equal; otherwise, <see langword="false" />.</returns>
         <remarks>
@@ -190,7 +190,7 @@ If `obj` is `null`, the method returns `false`.
         <Parameter Name="other" Type="System.Text.Json.JsonEncodedText" />
       </Parameters>
       <Docs>
-        <param name="other">To be added.</param>
+        <param name="other">The object to compare to this instance.</param>
         <summary>Determines whether this instance and another specified <see cref="T:System.Text.Json.JsonEncodedText" /> instance have the same value.</summary>
         <returns><see langword="true" /> if this instance and <paramref name="other" /> have the same value; otherwise, <see langword="false" />.</returns>
         <remarks>

From cd1ffccc4a1c64d21ebf013b0fcca60383d340ed Mon Sep 17 00:00:00 2001
From: Maira Wenzel <mairaw@microsoft.com>
Date: Thu, 1 Aug 2019 17:03:51 -0700
Subject: [PATCH 2/3] Update JsonStringEnumConverter.xml

---
 .../JsonStringEnumConverter.xml                        | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/xml/System.Text.Json.Serialization/JsonStringEnumConverter.xml b/xml/System.Text.Json.Serialization/JsonStringEnumConverter.xml
index 32243373f31..2a454193ebe 100644
--- a/xml/System.Text.Json.Serialization/JsonStringEnumConverter.xml
+++ b/xml/System.Text.Json.Serialization/JsonStringEnumConverter.xml
@@ -84,9 +84,9 @@ Reading is case insensitive. Writing can be customized by using a <xref:System.T
         <Parameter Name="typeToConvert" Type="System.Type" />
       </Parameters>
       <Docs>
-        <param name="typeToConvert">The type is checked as to whether it can be converted.</param>
-        <summary>Determines whether the type can be converted.</summary>
-        <returns><see langword="true" /> if the type can be converted; <see langword="false" /> otherwise.</returns>
+        <param name="typeToConvert">The type to be checked.</param>
+        <summary>Determines whether the specified type can be converted to an enum.</summary>
+        <returns><see langword="true" /> if the type can be converted; otherwise, <see langword="false" />.</returns>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
@@ -109,8 +109,8 @@ Reading is case insensitive. Writing can be customized by using a <xref:System.T
         <Parameter Name="typeToConvert" Type="System.Type" />
       </Parameters>
       <Docs>
-        <param name="typeToConvert">The <see cref="T:System.Type"/> being converted.</param>
-        <summary>Create a converter for the provided <see cref="T:System.Type"/>.</summary>
+        <param name="typeToConvert">The type to convert.</param>
+        <summary>Create a converter for the specified type.</summary>
         <returns>An instance of <see cref="T:System.Text.Json.Serialization.JsonConverter"/> of type T, where T is compatible with <paramref name="typeToConvert"/>.</returns>
         <remarks>To be added.</remarks>
       </Docs>

From 0e4b02e4a7c2daf9fceba2360afa6baf85d9b8aa Mon Sep 17 00:00:00 2001
From: Maira Wenzel <mairaw@microsoft.com>
Date: Thu, 1 Aug 2019 17:07:35 -0700
Subject: [PATCH 3/3] Update JsonElement.xml

---
 xml/System.Text.Json/JsonElement.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xml/System.Text.Json/JsonElement.xml b/xml/System.Text.Json/JsonElement.xml
index e657abd8f68..6aec1410bc2 100644
--- a/xml/System.Text.Json/JsonElement.xml
+++ b/xml/System.Text.Json/JsonElement.xml
@@ -838,8 +838,8 @@ This method does not parse the contents of a JSON string value.
       </Parameters>
       <Docs>
         <param name="index">The item index.</param>
-        <summary>Gets the value at a specified index when the current value is an <see cref="F:System.Text.Json.JsonValueKind.Array" />.</summary>
-        <value>A <see cref="T:System.Text.Json.JsonElement" /> located in the <paramref name="index" /> position.</value>
+        <summary>Gets the value at the specified index if the current value is an <see cref="F:System.Text.Json.JsonValueKind.Array" />.</summary>
+        <value>The value at the specified index.</value>
         <remarks>To be added.</remarks>
         <exception cref="T:System.InvalidOperationException">This value's <see cref="P:System.Text.Json.JsonElement.ValueKind" /> is not <see cref="F:System.Text.Json.JsonValueKind.Array" />.</exception>
         <exception cref="T:System.IndexOutOfRangeException"><paramref name="index" /> is not in the range [0, <see cref="M:System.Text.Json.JsonElement.GetArrayLength" />()).</exception>