From d7c5169d33272adef767a2e8ef8e8ddd6dc4c979 Mon Sep 17 00:00:00 2001
From: carlossanlop <calope@microsoft.com>
Date: Thu, 1 Aug 2019 13:49:22 -0700
Subject: [PATCH 1/2] Document System.Text.Json.JsonElement+ObjectEnumerator

---
 .../JsonElement+ObjectEnumerator.xml          | 28 ++++++++++---------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/xml/System.Text.Json/JsonElement+ObjectEnumerator.xml b/xml/System.Text.Json/JsonElement+ObjectEnumerator.xml
index dcfde4ad6c3..92d335f60cd 100644
--- a/xml/System.Text.Json/JsonElement+ObjectEnumerator.xml
+++ b/xml/System.Text.Json/JsonElement+ObjectEnumerator.xml
@@ -53,8 +53,8 @@
         <ReturnType>System.Text.Json.JsonProperty</ReturnType>
       </ReturnValue>
       <Docs>
-        <summary>To be added.</summary>
-        <value>To be added.</value>
+        <summary>Gets the element in the collection at the current position of the enumerator.</summary>
+        <value>The element in the collection at the current position of the enumerator.</value>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
@@ -78,7 +78,7 @@
       </ReturnValue>
       <Parameters />
       <Docs>
-        <summary>To be added.</summary>
+        <summary>Releases the resources used by this <see cref="T:System.Text.Json.JsonElement.ObjectEnumerator" /> instance.</summary>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
@@ -103,7 +103,9 @@
         <returns>An enumerator that can be used to iterate through the object.</returns>
         <remarks>
           <format><![CDATA[
-          
+
+## Remarks
+
 The enumerator will enumerate the properties in the order they are declared, and when an object has multiple definitions of a single property, they will all individually be returned (each in the order they appear in the content).
 
           ]]></format>
@@ -130,8 +132,8 @@ The enumerator will enumerate the properties in the order they are declared, and
       </ReturnValue>
       <Parameters />
       <Docs>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
+        <summary>Advances the enumerator to the next element of the collection.</summary>
+        <returns><see langword="true" /> if the enumerator was successfully advanced to the next element; <see langword="false" /> if the enumerator has passed the end of the collection.</returns>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
@@ -155,7 +157,7 @@ The enumerator will enumerate the properties in the order they are declared, and
       </ReturnValue>
       <Parameters />
       <Docs>
-        <summary>To be added.</summary>
+        <summary>Sets the enumerator to its initial position, which is before the first element in the collection.</summary>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
@@ -178,8 +180,8 @@ The enumerator will enumerate the properties in the order they are declared, and
       </ReturnValue>
       <Parameters />
       <Docs>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
+        <summary>Returns an enumerator that iterates through a collection.</summary>
+        <returns>An <see cref="T:System.Collections.Generic.IEnumerator" /> object for <see cref="T:System.Text.Json.JsonProperty" /> objects that can be used to iterate through the collection.</returns>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
@@ -202,8 +204,8 @@ The enumerator will enumerate the properties in the order they are declared, and
       </ReturnValue>
       <Parameters />
       <Docs>
-        <summary>To be added.</summary>
-        <returns>To be added.</returns>
+        <summary>Returns an enumerator that iterates through a collection.</summary>
+        <returns>An <see cref="T:System.Collections.Generic.IEnumerator" /> object that can be used to iterate through the collection.</returns>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
@@ -226,8 +228,8 @@ The enumerator will enumerate the properties in the order they are declared, and
         <ReturnType>System.Object</ReturnType>
       </ReturnValue>
       <Docs>
-        <summary>To be added.</summary>
-        <value>To be added.</value>
+        <summary>Gets the element in the collection at the current position of the enumerator.</summary>
+        <value>The element in the collection at the current position of the enumerator.</value>
         <remarks>To be added.</remarks>
       </Docs>
     </Member>

From 112694c9016df0c239a0d56d0b80633b458ba41a Mon Sep 17 00:00:00 2001
From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com>
Date: Mon, 5 Aug 2019 11:39:27 -0700
Subject: [PATCH 2/2] suggestions by rpetrusha

Co-Authored-By: Ron Petrusha <ronpet@microsoft.com>
---
 .../JsonElement+ObjectEnumerator.xml          | 22 ++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/xml/System.Text.Json/JsonElement+ObjectEnumerator.xml b/xml/System.Text.Json/JsonElement+ObjectEnumerator.xml
index 92d335f60cd..689929b762b 100644
--- a/xml/System.Text.Json/JsonElement+ObjectEnumerator.xml
+++ b/xml/System.Text.Json/JsonElement+ObjectEnumerator.xml
@@ -181,8 +181,14 @@ The enumerator will enumerate the properties in the order they are declared, and
       <Parameters />
       <Docs>
         <summary>Returns an enumerator that iterates through a collection.</summary>
-        <returns>An <see cref="T:System.Collections.Generic.IEnumerator" /> object for <see cref="T:System.Text.Json.JsonProperty" /> objects that can be used to iterate through the collection.</returns>
-        <remarks>To be added.</remarks>
+        <returns>An enumerator for <see cref="T:System.Text.Json.JsonProperty" /> objects that can be used to iterate through the collection.</returns>
+        <remarks>  
+          <format type="text/markdown"><![CDATA[  
+
+This member is an explicit interface member implementation. It can be used only when the <xref:System.Text.Json.JsonElement.ObjectEnumerator> instance is cast to an [IEnumerator<JsonProperty>](xref:System.Collections.Generic.IEnumerator%601) interface.
+
+         ]]></format>
+         </remarks>
       </Docs>
     </Member>
     <Member MemberName="System.Collections.IEnumerable.GetEnumerator">
@@ -205,8 +211,14 @@ The enumerator will enumerate the properties in the order they are declared, and
       <Parameters />
       <Docs>
         <summary>Returns an enumerator that iterates through a collection.</summary>
-        <returns>An <see cref="T:System.Collections.Generic.IEnumerator" /> object that can be used to iterate through the collection.</returns>
-        <remarks>To be added.</remarks>
+        <returns>An enumerator that can be used to iterate through the collection.</returns>
+        <remarks>  
+          <format type="text/markdown"><![CDATA[  
+
+This member is an explicit interface member implementation. It can be used only when the <xref:System.Text.Json.JsonElement.ObjectEnumerator> instance is cast to an <xref:System.Collections.IEnumerable> interface.
+
+         ]]></format>
+         </remarks>
       </Docs>
     </Member>
     <Member MemberName="System.Collections.IEnumerator.Current">
@@ -234,4 +246,4 @@ The enumerator will enumerate the properties in the order they are declared, and
       </Docs>
     </Member>
   </Members>
-</Type>
\ No newline at end of file
+</Type>