From fed9a42c607b8a90f2a5ee8fe3384d1eb7583c32 Mon Sep 17 00:00:00 2001 From: carlossanlop Date: Tue, 30 Jul 2019 16:58:39 -0700 Subject: [PATCH 1/5] Automatically port System.Text.Json.Serialization.JsonConverter --- xml/System.Text.Json.Serialization/JsonConverter.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xml/System.Text.Json.Serialization/JsonConverter.xml b/xml/System.Text.Json.Serialization/JsonConverter.xml index 57896b6ae0f..2cea35e688b 100644 --- a/xml/System.Text.Json.Serialization/JsonConverter.xml +++ b/xml/System.Text.Json.Serialization/JsonConverter.xml @@ -14,7 +14,7 @@ - To be added. + Converts an object or value to or from JSON. To be added. @@ -37,9 +37,9 @@ - To be added. - To be added. - To be added. + The type is checked as to whether it can be converted. + Determines whether the type can be converted. + if the type can be converted, otherwise. To be added. From 62ad1938e0c029c3dcb61e968e326ed31f8897fc Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Thu, 1 Aug 2019 10:21:07 -0700 Subject: [PATCH 2/5] suggestions by rpetrusha and Jozkee Co-Authored-By: David Cantu --- xml/System.Text.Json.Serialization/JsonConverter.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xml/System.Text.Json.Serialization/JsonConverter.xml b/xml/System.Text.Json.Serialization/JsonConverter.xml index 2cea35e688b..192de514e72 100644 --- a/xml/System.Text.Json.Serialization/JsonConverter.xml +++ b/xml/System.Text.Json.Serialization/JsonConverter.xml @@ -37,11 +37,11 @@ - The type is checked as to whether it can be converted. - Determines whether the type can be converted. - if the type can be converted, otherwise. + The type to compare against. + When overriden in a derived class, determines whether the converter can convert the specified type. + if the type can be converted; otherwise, . To be added. - \ No newline at end of file + From c133c12512898fc425b54ab2354e0d27a2fb0c76 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Thu, 1 Aug 2019 14:01:47 -0700 Subject: [PATCH 3/5] suggestion by Jozkee Co-Authored-By: David Cantu --- xml/System.Text.Json.Serialization/JsonConverter.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Text.Json.Serialization/JsonConverter.xml b/xml/System.Text.Json.Serialization/JsonConverter.xml index 192de514e72..3b31315a6fe 100644 --- a/xml/System.Text.Json.Serialization/JsonConverter.xml +++ b/xml/System.Text.Json.Serialization/JsonConverter.xml @@ -38,7 +38,7 @@ The type to compare against. - When overriden in a derived class, determines whether the converter can convert the specified type. + When overridden in a derived class, determines whether the converter can convert the specified type. if the type can be converted; otherwise, . To be added. From 9ecb192eb4e6a0d37dee62dd739a83adc4878e5c Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Fri, 2 Aug 2019 13:33:37 -0700 Subject: [PATCH 4/5] suggestions by ahsonkhan Co-Authored-By: Ahson Khan --- xml/System.Text.Json.Serialization/JsonConverter.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Text.Json.Serialization/JsonConverter.xml b/xml/System.Text.Json.Serialization/JsonConverter.xml index 3b31315a6fe..ca887fcb3ca 100644 --- a/xml/System.Text.Json.Serialization/JsonConverter.xml +++ b/xml/System.Text.Json.Serialization/JsonConverter.xml @@ -38,8 +38,8 @@ The type to compare against. - When overridden in a derived class, determines whether the converter can convert the specified type. - if the type can be converted; otherwise, . + When overridden in a derived class, determines whether the converter instance can convert the specified object type. + if the instance can convert the specified object type; otherwise, . To be added. From f88c1c01d43743ab6f8041cc34bfad382b3d5c94 Mon Sep 17 00:00:00 2001 From: Carlos Sanchez Lopez <1175054+carlossanlop@users.noreply.github.com> Date: Mon, 5 Aug 2019 11:40:31 -0700 Subject: [PATCH 5/5] suggestion by ahsonkhan Co-Authored-By: Ahson Khan --- xml/System.Text.Json.Serialization/JsonConverter.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xml/System.Text.Json.Serialization/JsonConverter.xml b/xml/System.Text.Json.Serialization/JsonConverter.xml index ca887fcb3ca..414147440fe 100644 --- a/xml/System.Text.Json.Serialization/JsonConverter.xml +++ b/xml/System.Text.Json.Serialization/JsonConverter.xml @@ -37,7 +37,7 @@ - The type to compare against. + The type of the object to check whether it can be converted by this converter instance. When overridden in a derived class, determines whether the converter instance can convert the specified object type. if the instance can convert the specified object type; otherwise, . To be added.