Skip to content

Document two System.Runtime APIs #2874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2019
Merged

Document two System.Runtime APIs #2874

merged 4 commits into from
Jul 30, 2019

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Jul 30, 2019

Found a couple of misplaced descriptions in System.Runtime.CompilerServices.RuntimeFeature.IsDynamicCodeCompiled.
Documented summary for System.Runtime.Loader.AssemblyLoadContext.Finalize.

@carlossanlop carlossanlop added new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 labels Jul 30, 2019
@carlossanlop carlossanlop added this to the July 2019 milestone Jul 30, 2019
@carlossanlop carlossanlop self-assigned this Jul 30, 2019
@mairaw mairaw modified the milestones: July 2019, August 2019 Jul 30, 2019
mairaw
mairaw approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mairaw mairaw merged commit e93e162 into dotnet:master Jul 30, 2019
@mairaw mairaw removed verify-build-before-merge waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Jul 30, 2019
@carlossanlop carlossanlop deleted the System.Runtime branch September 22, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mairaw mairaw mairaw approved these changes

@rpetrusha rpetrusha Awaiting requested review from rpetrusha

+1 more reviewer

@Anipik Anipik Anipik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carlossanlop carlossanlop

Labels

🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles

Projects

None yet

Milestone

August 2019

Development

Successfully merging this pull request may close these issues.

3 participants

@carlossanlop @Anipik @mairaw