Document System.Reflection.Metadata.ImageFormatLimitationException #2872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
new-content
carlossanlop
requested review from
joperezr,
mairaw,
nguerrera,
rpetrusha and
tmat
tmat
reviewed
Jul 30, 2019
xml/System.Reflection.Metadata/ImageFormatLimitationException.xml
Outdated
Show resolved
Hide resolved
rpetrusha
suggested changes
Jul 30, 2019
rpetrusha
left a comment
rpetrusha
left a comment
There was a problem hiding this comment.
I've made some changes, @carlossanlop, as well as documented the remaining constructor overloads, if you'd like to review them. In addition, @tmat has suggested that the type description be modified.
rpetrusha
approved these changes
Jul 30, 2019
rpetrusha
added
verify-build-before-merge
and removed
waiting-on-reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documenting the 3.0 serialization API added recently by @joperezr.
Added also a general summary. There were no comments in the source, and the exception is older than .NET Core, so I based my summary on the way it's being used in corefx. The area owners are @tmat, @nguerrera. Can you please help make sure the summary is correct?