Automatically port System.IO triple slash comments #2675
Conversation
|
@JeremyKuhne can you please double check the comments I added are correct? |
mairaw
added
🏁 Release: .NET Core 3.0
mairaw
left a comment
mairaw
left a comment
There was a problem hiding this comment.
My review comments so far. Need to continue the review starting at FileSystemName.xml.
JeremyKuhne
left a comment
JeremyKuhne
left a comment
There was a problem hiding this comment.
Some initial feedback on technical correctness.
Co-Authored-By: Maira Wenzel <[email protected]>
carlossanlop
added
the
changes-addressed
|
I'll start re-reviewing this one now but the build report has a couple of broken links for this PR. Do you want to take a look @carlossanlop? |
| <param name="expression">The expression to match with.</param> | ||
| <param name="name">The name to check against the expression.</param> | ||
| <param name="ignoreCase"><see langword="true" /> to ignore case (default), <see langword="false" /> if the match should be case-sensitive.</param> | ||
| <summary>Verifies if the given expression matches the given name. Supports the following wildcards: '*' and '?'. The backslash character '\' escapes.</summary> |
There was a problem hiding this comment.
The \ character is not rendering on docs. I'll need to check with the eng team about this. Probably escaping would fix it for docs but could break IntelliSense.
There was a problem hiding this comment.
Could we use its html entity?
https://www.freeformatter.com/html-entities.html
\
There was a problem hiding this comment.
We can try. Should we merge this and figure out on a separate PR how to fix this?
There was a problem hiding this comment.
Okay sure, let's get it merged. I can address it separately.
mairaw
added
waiting-on-feedback
|
@carlossanlop @JeremyKuhne do you want to review the changes I made? |
|
I reviewed your commits, thank you for making those changes. They look good. |
carlossanlop
added
verify-build-before-merge
and removed
waiting-on-feedback
|
I've fixed the broken crefs, so this should be ready to merge when the build completes. |
4 participants
Found a new batch of System.IO triple slash comments that can be ported. Also manually added a few others.