Rid-specific app breaking change #35656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
nagilson
reviewed
Jun 5, 2023
Member
There was a problem hiding this comment.
Thanks for this! 🎆 I appreciate that you condensed it down and for adding the links to make a clean doc. And I love all of the links to the different sub-components like what selfcontained is. There are still some changes that are needed but overall it looks great!
Also, @sbomer @vitek-karas @agocke @eerhardt it'd be good to have one of you take a glance at the publish property and IL Link comments to make sure it's accurate. Thank you :)
Member
|
cc @baronfel @richlander for increased visibility |
vitek-karas
reviewed
Jun 6, 2023
vitek-karas
reviewed
Jun 6, 2023
vitek-karas
reviewed
Jun 6, 2023
vitek-karas
reviewed
Jun 6, 2023
eerhardt
reviewed
Jun 6, 2023
gewarren
commented
Jun 6, 2023
Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Vitek Karas <[email protected]>
adegeo
reviewed
Jun 6, 2023
Member
|
@gewarren Thank you for following up on our feedback :) This is a pretty big change so this is really good to have. And thanks @vitek-karas and @eerhardt for also chiming in on the implementation side |
gewarren
commented
Jun 7, 2023
nagilson
reviewed
Jun 7, 2023
Co-authored-by: Noah Gilson <[email protected]>
Member
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33726
Internal previews