Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit dcf529d

Browse files
Merge pull request #13096 from hseok-oh/ryujit/remove_nyi_promote
[RyuJIT/ARM32] Remove NYI: promoted struct argument
2 parents ed4f7f7 + 0667420 commit dcf529d

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

src/jit/codegenarmarch.cpp

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -666,17 +666,10 @@ void CodeGen::genPutArgStk(GenTreePutArgStk* treeNode)
666666
assert(varNumInp < compiler->lvaCount);
667667
LclVarDsc* varDsc = &compiler->lvaTable[varNumInp];
668668

669+
// This struct also must live in the stack frame
670+
// And it can't live in a register (SIMD)
669671
assert(varDsc->lvType == TYP_STRUCT);
670-
#ifdef _TARGET_ARM_
671-
if (varDsc->lvPromoted)
672-
{
673-
NYI_ARM("CodeGen::genPutArgStk - promoted struct");
674-
}
675-
else
676-
#endif // _TARGET_ARM_
677-
// This struct also must live in the stack frame
678-
// And it can't live in a register (SIMD)
679-
assert(varDsc->lvOnFrame && !varDsc->lvRegister);
672+
assert(varDsc->lvOnFrame && !varDsc->lvRegister);
680673

681674
structSize = varDsc->lvSize(); // This yields the roundUp size, but that is fine
682675
// as that is how much stack is allocated for this LclVar
@@ -1015,10 +1008,11 @@ void CodeGen::genPutArgSplit(GenTreePutArgSplit* treeNode)
10151008

10161009
// handle promote situation
10171010
LclVarDsc* varDsc = compiler->lvaTable + srcVarNum;
1018-
if (varDsc->lvPromoted)
1019-
{
1020-
NYI_ARM("CodeGen::genPutArgSplit - promoted struct");
1021-
}
1011+
1012+
// This struct also must live in the stack frame
1013+
// And it can't live in a register (SIMD)
1014+
assert(varDsc->lvType == TYP_STRUCT);
1015+
assert(varDsc->lvOnFrame && !varDsc->lvRegister);
10221016

10231017
// We don't split HFA struct
10241018
assert(!varDsc->lvIsHfa());

0 commit comments

Comments
 (0)