Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@Petermarcu
Copy link
Member

This adds support for arm and arm64 rids to address https://github.com/dotnet/core-setup/issues/4081

@Petermarcu Petermarcu changed the title Updating arch support for arm ** NO MERGE ***Updating arch support for arm Apr 26, 2018
@Petermarcu
Copy link
Member Author

I haven't been able to build and test locally on different arch's so marking this a no merge.

@Petermarcu Petermarcu requested a review from eerhardt April 27, 2018 03:33
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It looks like the host already has the correct code for ARM architectures, so we should be good there:

const pal::char_t* get_arch()
{
#if _TARGET_AMD64_
return _X("x64");
#elif _TARGET_X86_
return _X("x86");
#elif _TARGET_ARM_
return _X("arm");
#elif _TARGET_ARM64_
return _X("arm64");
#else
#error "Unknown target"
#endif
}

return $"-{RuntimeArchitecture.ToLowerInvariant()}";
}
return string.Empty;
return $"-{RuntimeArchitecture}";

This comment was marked as spam.

@Petermarcu Petermarcu changed the title ** NO MERGE ***Updating arch support for arm Updating arch support for arm Apr 30, 2018
@Petermarcu
Copy link
Member Author

Finished verifying this on my Pi and confirmed we now have the correct behavior.

@Petermarcu Petermarcu merged commit 63dcd37 into dotnet:master Apr 30, 2018
Petermarcu added a commit that referenced this pull request Apr 30, 2018
* Updating arch support for arm

* Switching to process instead of OS arch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants