Move | replacement to IsMatch method

Author: tdashworth

src/System.CommandLine/Binding/Binder.cs

@@ -9,7 +9,8 @@ internal static class Binder
     {
         internal static bool IsMatch(this string parameterName, string alias) =>
             string.Equals(alias?.RemovePrefix()
-                              .Replace("-", ""),
+                              .Replace("-", "")
+                              .Replace("|", "or"),
                           parameterName,
                           StringComparison.OrdinalIgnoreCase);
 

src/System.CommandLine/Parsing/CommandResultExtensions.cs

@@ -36,7 +36,7 @@ internal static bool TryGetValueForArgument(
             {
                 foreach (var argument in commandResult.Command.Arguments)
                 {
-                    if (valueName.IsMatch(argument.Name) || valueName.IsMatch(argument.Name.Replace("|","or")))
+                    if (valueName.IsMatch(argument.Name))
                     {
                         value = commandResult.ArgumentConversionResults[argument.Name]?.GetValueOrDefault();
                         return true;