Clean up files a bit (#1790)

* Remove unnecessary using statements

* Simplify to new(...)

* Minor Fixes

Author: BenjaminMichaelis

src/System.CommandLine.ApiCompatibility.Tests/ApiCompatibilityApprovalTests.cs

@@ -3,7 +3,6 @@
 
 using System.CommandLine.Hosting;
 using System.CommandLine.NamingConventionBinder;
-using System.CommandLine.Parsing;
 using ApprovalTests;
 using ApprovalTests.Reporters;
 using Xunit;

src/System.CommandLine.Benchmarks/CommandLine/Perf_Parser_Directives_Suggest.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System.CommandLine.Benchmarks.Helpers;
-using System.CommandLine.Invocation;
 using System.CommandLine.Parsing;
 using System.Threading.Tasks;
 using BenchmarkDotNet.Attributes;

src/System.CommandLine.Benchmarks/CommandLine/Perf_Parser_NestedCommands.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System.CommandLine.Parsing;
-using System.Linq;
 using BenchmarkDotNet.Attributes;
 
 namespace System.CommandLine.Benchmarks.CommandLine
@@ -40,7 +39,7 @@ private void GenerateTestNestedCommands(Command parent, int depth, int countPerL
             for (int i = 0; i < countPerLevel; i++)
             {
                 string cmdName = $"{parent.Name}_{depth}.{i}";
-                Command cmd = new Command(cmdName);
+                Command cmd = new(cmdName);
                 parent.AddCommand(cmd);
                 GenerateTestNestedCommands(cmd, depth - 1, countPerLevel);
             }
@@ -73,7 +72,7 @@ public void SetupParser()
         }
 
         [Benchmark]
-        public Parser ParserFromNestedCommands_Ctor() => new Parser(_rootCommand);
+        public Parser ParserFromNestedCommands_Ctor() => new(_rootCommand);
 
         [Benchmark]
         public ParseResult Parser_Parse() => _testParser.Parse(_testSymbolsAsString);

src/System.CommandLine.Benchmarks/CommandLine/Perf_Parser_Simple.cs

@@ -1,5 +1,4 @@
 using BenchmarkDotNet.Attributes;
-using System.CommandLine.Invocation;
 using System.CommandLine.Parsing;
 using System.Threading.Tasks;
 
@@ -25,10 +24,10 @@ public class Perf_Parser_Simple
 
         private static RootCommand BuildCommand()
         {
-            Option<bool> boolOption = new Option<bool>(new[] { "--bool", "-b" }, "Bool option");
-            Option<string> stringOption = new Option<string>(new[] { "--string", "-s" }, "String option");
+            Option<bool> boolOption = new(new[] { "--bool", "-b" }, "Bool option");
+            Option<string> stringOption = new(new[] { "--string", "-s" }, "String option");
 
-            RootCommand command = new RootCommand
+            RootCommand command = new()
             {
                 boolOption,
                 stringOption

src/System.CommandLine.Benchmarks/CommandLine/Perf_Suggestions.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System.Collections.Generic;
-using System.CommandLine.Parsing;
 using System.Linq;
 using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Engines;

src/System.CommandLine.Benchmarks/DragonFruit/Perf_CommandLine_EntryPoint.cs

@@ -20,7 +20,7 @@ namespace System.CommandLine.Benchmarks.DragonFruit
     [InvocationCount(3000)]
     public class Perf_CommandLine_EntryPoint
     {
-        private readonly NullConsole _nullConsole = new NullConsole();
+        private readonly NullConsole _nullConsole = new();
         private Assembly _testAssembly;
         private string _testAssemblyFilePath;
         private string _testAssemblyXmlDocsFilePath;

src/System.CommandLine.Benchmarks/DragonFruit/Perf_CommandLine_Help.cs

@@ -17,7 +17,7 @@ namespace System.CommandLine.Benchmarks.DragonFruit
     [InvocationCount(3000)]
     public class Perf_CommandLine_Help
     {
-        private readonly NullConsole _nullConsole = new NullConsole();
+        private readonly NullConsole _nullConsole = new();
         private Assembly _testAssembly;
         private string _testAssemblyFilePath;
         private string _testAssemblyXmlDocsFilePath;

src/System.CommandLine.Benchmarks/Helpers/NullConsole.cs

@@ -7,7 +7,7 @@ namespace System.CommandLine.Benchmarks.Helpers
 {
     class NullConsole : IConsole
     {
-        readonly NullStreamWriter _nullWriter = new NullStreamWriter();
+        readonly NullStreamWriter _nullWriter = new();
 
         public IStandardStreamWriter Out => _nullWriter;
         public IStandardStreamWriter Error => _nullWriter;

src/System.CommandLine.Benchmarks/Program.cs

@@ -1,11 +1,11 @@
 // Copyright (c) .NET Foundation and contributors. All rights reserved.
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
-using System.Collections.Immutable;
-using System.IO;
 using BenchmarkDotNet.Running;
 using System.Linq;
 using BenchmarkDotNet.Configs;
+using System.Collections.Immutable;
+using System.IO;
 
 namespace System.CommandLine.Benchmarks
 {

src/System.CommandLine.DragonFruit.Tests/CommandLineTests.cs

@@ -2,7 +2,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 
 using System.CommandLine.Rendering;
-using System.ComponentModel;
 using System.Threading.Tasks;
 using FluentAssertions;
 using Xunit;