Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

compile-fsc, support debugType and fix #2076

Merged
merged 2 commits into from
Mar 26, 2016
Merged

compile-fsc, support debugType and fix #2076

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c39678d
support project.json compilationOptions.debugType in fsc
enricosada Mar 25, 2016
ac05fde
fsc, always pass --nocopyfsharpcore to disable copy of FSharp.Core to…
enricosada Mar 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/dotnet/commands/dotnet-compile-fsc/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,20 +104,32 @@ public static int Run(string[] args)
allArgs.Add($"--out:{outputName}");
}

//debug info (only windows pdb supported, not portablepdb)
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
//let's pass debugging type only if options.DebugType is specified, until
//portablepdb are confirmed to work.
//so it's possibile to test portable pdb without breaking existing build
if (string.IsNullOrEmpty(commonOptions.DebugType))
{
allArgs.Add("--debug");
//TODO check if full or pdbonly
allArgs.Add("--debug:pdbonly");
//debug info (only windows pdb supported, not portablepdb)
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
allArgs.Add("--debug");
//TODO check if full or pdbonly
allArgs.Add("--debug:pdbonly");
}
else
allArgs.Add("--debug-");
}
else
allArgs.Add("--debug-");
{
allArgs.Add("--debug");
allArgs.Add($"--debug:{commonOptions.DebugType}");
}

// Default options
allArgs.Add("--noframework");
allArgs.Add("--nologo");
allArgs.Add("--simpleresolution");
allArgs.Add("--nocopyfsharpcore");

// project.json compilationOptions
if (commonOptions.Defines != null)
Expand Down