Skip to content

Conversation

@HaoK
Copy link
Member

@HaoK HaoK commented Apr 2, 2019

Depends on #8577

@HaoK HaoK added the area-identity Includes: Identity and providers label Apr 2, 2019
@HaoK HaoK force-pushed the haok-templates branch from 0e7032c to 1d5a460 Compare April 2, 2019 23:26
@HaoK HaoK marked this pull request as ready for review April 3, 2019 04:53
@HaoK HaoK requested a review from ryanbrandenburg as a code owner April 3, 2019 04:53
@HaoK HaoK requested review from ajcvickers and blowdart April 3, 2019 04:53
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine but are we sure this is a scenario we want as a default experience for the templates?

@HaoK
Copy link
Member Author

HaoK commented Apr 3, 2019

@blowdart ?

@blowdart
Copy link
Contributor

blowdart commented Apr 4, 2019

As discussed, after branching happens.

@HaoK
Copy link
Member Author

HaoK commented Jun 18, 2019

@blowdart still good to merge and turn this on for preview 7?

@blowdart
Copy link
Contributor

Yes, we want the feedback.

Copy link
Contributor

@blowdart blowdart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do it, let's get the feedback

@HaoK HaoK merged commit 2191f07 into master Jun 18, 2019
@HaoK HaoK deleted the haok-templates branch June 18, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-identity Includes: Identity and providers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants