From 350ea9f317efb363d79e37e144a73d1e365dc7c0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= <alex.koeplinger@outlook.com>
Date: Wed, 4 Dec 2024 15:01:21 +0100
Subject: [PATCH] Remove setting IsStableBuild in Directory.Build.props

It is a no-op.

Arcade already sets this in https://github.com/dotnet/arcade/blob/7fff497cdf80039a4f2996699e5561e50812d948/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L55-L57 and as we discovered in https://github.com/dotnet/aspnetcore/pull/59309 the DotNetFinalVersionKind property isn't even set at that point.
---
 Directory.Build.props | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/Directory.Build.props b/Directory.Build.props
index af93bd708f4d..650d35898837 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -48,15 +48,6 @@
         '$(IsBenchmarkProject)' == 'true' OR
         '$(IsPublishedAppTestProject)' == 'true' OR
         $(IsUnitTestProject) ">false</IsShipping>
-
-    <!--
-      Following logic mimics core-setup approach as well as
-      https://github.com/dotnet/arcade/blob/694d59f090b743f894779d04a7ffe11cbaf352e7/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L30-L31
-      $(DotNetFinalVersionKind) is set globally when doing final aka stable builds. Arcade infrastructure should pick
-      up $(IsStableBuild) automatically; property is also used to control prerelease branding.
-    -->
-    <IsStableBuild>false</IsStableBuild>
-    <IsStableBuild Condition=" '$(DotNetFinalVersionKind)' == 'release' ">true</IsStableBuild>
   </PropertyGroup>
 
   <!-- Disable logging of some task parameters or metadata to reduce binlog size.