From 03139339ab346b516f07f36ede4734d1b2ceb8d0 Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Thu, 19 Sep 2024 18:08:22 -0700 Subject: [PATCH 1/8] Unquarantine https://github.com/dotnet/aspnetcore/issues/54754 --- src/Components/test/E2ETest/Tests/ThreadingAppTest.cs | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/Components/test/E2ETest/Tests/ThreadingAppTest.cs b/src/Components/test/E2ETest/Tests/ThreadingAppTest.cs index b50b5e787977..c0312202407d 100644 --- a/src/Components/test/E2ETest/Tests/ThreadingAppTest.cs +++ b/src/Components/test/E2ETest/Tests/ThreadingAppTest.cs @@ -28,14 +28,12 @@ protected override void InitializeAsyncCore() } [Fact] - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54754")] public void HasTitle() { Assert.Equal("Blazor standalone", Browser.Title); } [Fact] - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54754")] public void HasHeading() { Assert.Equal("Hello, world!", Browser.Exists(By.TagName("h1")).Text); @@ -69,7 +67,6 @@ public void NavMenuHighlightsCurrentLocation() } [Fact] - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54754")] public void CounterPageCanUseThreads() { // Navigate to "Counter" @@ -87,7 +84,6 @@ public void CounterPageCanUseThreads() } [Fact] - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54754")] public void HasFetchDataPage() { // Navigate to "Fetch data" @@ -109,7 +105,6 @@ public void HasFetchDataPage() } [Fact] - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54754")] public void IsStarted() { // Read from property From bc6dbaaeea1edc01e3268473185e1af90dc464d6 Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Thu, 19 Sep 2024 18:09:38 -0700 Subject: [PATCH 2/8] Unquarantine https://github.com/dotnet/aspnetcore/issues/54447 --- .../FormHandlingTests/FormWithParentBindingContextTest.cs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Components/test/E2ETest/ServerRenderingTests/FormHandlingTests/FormWithParentBindingContextTest.cs b/src/Components/test/E2ETest/ServerRenderingTests/FormHandlingTests/FormWithParentBindingContextTest.cs index 8b90ae878f2a..6afe7639ee83 100644 --- a/src/Components/test/E2ETest/ServerRenderingTests/FormHandlingTests/FormWithParentBindingContextTest.cs +++ b/src/Components/test/E2ETest/ServerRenderingTests/FormHandlingTests/FormWithParentBindingContextTest.cs @@ -8,7 +8,6 @@ using Microsoft.AspNetCore.Components.E2ETest.Infrastructure; using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures; using Microsoft.AspNetCore.E2ETesting; -using Microsoft.AspNetCore.InternalTesting; using OpenQA.Selenium; using TestServer; using Xunit.Abstractions; @@ -1251,7 +1250,6 @@ public void PostingFormWithErrorsDoesNotExceedMaximumErrors() } [Fact] - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54447")] public void CanBindToFormWithFiles() { var profilePicture = TempFile.Create(_tempDirectory, "txt", "This is a profile picture."); From 763b6c6a96cfc043ce3d5b497e5887659d1f3b8c Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Thu, 19 Sep 2024 18:16:37 -0700 Subject: [PATCH 3/8] Unquarantine https://github.com/dotnet/aspnetcore/issues/57153 --- .../ServerExecutionTests/NavigationLockPrerenderingTest.cs | 2 -- src/Components/test/E2ETest/Tests/RoutingTest.cs | 1 - 2 files changed, 3 deletions(-) diff --git a/src/Components/test/E2ETest/ServerExecutionTests/NavigationLockPrerenderingTest.cs b/src/Components/test/E2ETest/ServerExecutionTests/NavigationLockPrerenderingTest.cs index 645a29cc7bfa..d60065299d62 100644 --- a/src/Components/test/E2ETest/ServerExecutionTests/NavigationLockPrerenderingTest.cs +++ b/src/Components/test/E2ETest/ServerExecutionTests/NavigationLockPrerenderingTest.cs @@ -4,7 +4,6 @@ using Microsoft.AspNetCore.Components.E2ETest.Infrastructure; using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures; using Microsoft.AspNetCore.E2ETesting; -using Microsoft.AspNetCore.InternalTesting; using OpenQA.Selenium; using TestServer; using Xunit.Abstractions; @@ -25,7 +24,6 @@ public override Task InitializeAsync() => InitializeAsync(BrowserFixture.RoutingTestContext); [Fact] - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57153")] public void NavigationIsLockedAfterPrerendering() { Navigate("/locked-navigation"); diff --git a/src/Components/test/E2ETest/Tests/RoutingTest.cs b/src/Components/test/E2ETest/Tests/RoutingTest.cs index 3b9ad5e8bf84..f5d5d3bb8473 100644 --- a/src/Components/test/E2ETest/Tests/RoutingTest.cs +++ b/src/Components/test/E2ETest/Tests/RoutingTest.cs @@ -1085,7 +1085,6 @@ public void NavigationLock_HistoryNavigationWorks_AfterRefresh() } [Fact] - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57153")] public void NavigationLock_CanBlockExternalNavigation() { SetUrlViaPushState("/"); From acc6e231926ea32935e3ab996b04feb06ba325ab Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Thu, 19 Sep 2024 18:17:53 -0700 Subject: [PATCH 4/8] Unquarantine https://github.com/dotnet/aspnetcore/issues/47967 - This appears to have been missed --- src/Components/test/E2ETest/Tests/RoutingTest.cs | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/Components/test/E2ETest/Tests/RoutingTest.cs b/src/Components/test/E2ETest/Tests/RoutingTest.cs index f5d5d3bb8473..be95d7b7e33f 100644 --- a/src/Components/test/E2ETest/Tests/RoutingTest.cs +++ b/src/Components/test/E2ETest/Tests/RoutingTest.cs @@ -9,7 +9,6 @@ using Microsoft.AspNetCore.Components.E2ETest.Infrastructure; using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures; using Microsoft.AspNetCore.E2ETesting; -using Microsoft.AspNetCore.InternalTesting; using OpenQA.Selenium; using OpenQA.Selenium.Interactions; using Xunit.Abstractions; @@ -1678,7 +1677,6 @@ public void AnchorWithHrefToSameUrlWithParamQueryAndHash_ScrollsToElementOnTheSa } [Fact] - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/47967")] public void AnchorWithHrefContainingHashAnotherPage_NavigatesToPageAndScrollsToElement() { SetUrlViaPushState("/"); @@ -1695,7 +1693,6 @@ public void AnchorWithHrefContainingHashAnotherPage_NavigatesToPageAndScrollsToE } [Fact] - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/47967")] public void NavigationManagerNavigateToAnotherUrlWithHash_NavigatesToPageAndScrollsToElement() { SetUrlViaPushState("/"); From efbbf3b699ba86568f78146adb8f3a9304b4f1b5 Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Thu, 19 Sep 2024 18:24:03 -0700 Subject: [PATCH 5/8] Unquarantine https://github.com/dotnet/aspnetcore/issues/57259 --- src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs | 1 - src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs | 1 - 2 files changed, 2 deletions(-) diff --git a/src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs b/src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs index 3eac7ed0a781..051a0c19826c 100644 --- a/src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs +++ b/src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs @@ -22,7 +22,6 @@ namespace Microsoft.AspNetCore.Hosting.Tests; public class HostingApplicationDiagnosticsTests : LoggedTest { [Fact] - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57259")] public async Task EventCountersAndMetricsValues() { // Arrange diff --git a/src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs b/src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs index e9dfd3ec04b3..7a34d20147be 100644 --- a/src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs +++ b/src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs @@ -176,7 +176,6 @@ public void UnhandledException() } [Fact] - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57259")] public async Task VerifyCountersFireWithCorrectValues() { // Arrange From bb76b9b666a6cdccde18d3eb4b1c629df0176dca Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Fri, 20 Sep 2024 13:37:45 -0700 Subject: [PATCH 6/8] Revert "Unquarantine https://github.com/dotnet/aspnetcore/issues/57259" This reverts commit efbbf3b699ba86568f78146adb8f3a9304b4f1b5. --- src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs | 1 + src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs | 1 + 2 files changed, 2 insertions(+) diff --git a/src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs b/src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs index 051a0c19826c..3eac7ed0a781 100644 --- a/src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs +++ b/src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs @@ -22,6 +22,7 @@ namespace Microsoft.AspNetCore.Hosting.Tests; public class HostingApplicationDiagnosticsTests : LoggedTest { [Fact] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57259")] public async Task EventCountersAndMetricsValues() { // Arrange diff --git a/src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs b/src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs index 7a34d20147be..e9dfd3ec04b3 100644 --- a/src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs +++ b/src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs @@ -176,6 +176,7 @@ public void UnhandledException() } [Fact] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57259")] public async Task VerifyCountersFireWithCorrectValues() { // Arrange From e861fd13004406258d2374d0a26f9a5f76cab9cd Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Sun, 22 Sep 2024 13:07:20 -0700 Subject: [PATCH 7/8] Revert "Unquarantine https://github.com/dotnet/aspnetcore/issues/57153" This reverts commit 763b6c6a96cfc043ce3d5b497e5887659d1f3b8c. --- .../ServerExecutionTests/NavigationLockPrerenderingTest.cs | 2 ++ src/Components/test/E2ETest/Tests/RoutingTest.cs | 1 + 2 files changed, 3 insertions(+) diff --git a/src/Components/test/E2ETest/ServerExecutionTests/NavigationLockPrerenderingTest.cs b/src/Components/test/E2ETest/ServerExecutionTests/NavigationLockPrerenderingTest.cs index d60065299d62..645a29cc7bfa 100644 --- a/src/Components/test/E2ETest/ServerExecutionTests/NavigationLockPrerenderingTest.cs +++ b/src/Components/test/E2ETest/ServerExecutionTests/NavigationLockPrerenderingTest.cs @@ -4,6 +4,7 @@ using Microsoft.AspNetCore.Components.E2ETest.Infrastructure; using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures; using Microsoft.AspNetCore.E2ETesting; +using Microsoft.AspNetCore.InternalTesting; using OpenQA.Selenium; using TestServer; using Xunit.Abstractions; @@ -24,6 +25,7 @@ public override Task InitializeAsync() => InitializeAsync(BrowserFixture.RoutingTestContext); [Fact] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57153")] public void NavigationIsLockedAfterPrerendering() { Navigate("/locked-navigation"); diff --git a/src/Components/test/E2ETest/Tests/RoutingTest.cs b/src/Components/test/E2ETest/Tests/RoutingTest.cs index be95d7b7e33f..99bd77f41b62 100644 --- a/src/Components/test/E2ETest/Tests/RoutingTest.cs +++ b/src/Components/test/E2ETest/Tests/RoutingTest.cs @@ -1084,6 +1084,7 @@ public void NavigationLock_HistoryNavigationWorks_AfterRefresh() } [Fact] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/57153")] public void NavigationLock_CanBlockExternalNavigation() { SetUrlViaPushState("/"); From 54ce196d2566851cf5a4bc03c44fdd7e73466969 Mon Sep 17 00:00:00 2001 From: Stephen Halter Date: Mon, 23 Sep 2024 09:37:01 -0700 Subject: [PATCH 8/8] Add back InternalTesting using --- src/Components/test/E2ETest/Tests/RoutingTest.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Components/test/E2ETest/Tests/RoutingTest.cs b/src/Components/test/E2ETest/Tests/RoutingTest.cs index 99bd77f41b62..188e7c71f3bf 100644 --- a/src/Components/test/E2ETest/Tests/RoutingTest.cs +++ b/src/Components/test/E2ETest/Tests/RoutingTest.cs @@ -9,6 +9,7 @@ using Microsoft.AspNetCore.Components.E2ETest.Infrastructure; using Microsoft.AspNetCore.Components.E2ETest.Infrastructure.ServerFixtures; using Microsoft.AspNetCore.E2ETesting; +using Microsoft.AspNetCore.InternalTesting; using OpenQA.Selenium; using OpenQA.Selenium.Interactions; using Xunit.Abstractions;