From a43e88ef9e5706e753bafb743f6d66164ce6cc7a Mon Sep 17 00:00:00 2001
From: Smaug123 <3138005+Smaug123@users.noreply.github.com>
Date: Tue, 10 Sep 2024 08:27:14 +0100
Subject: [PATCH 1/2] Note fire-and-forget status of HubConnection event tasks
---
src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs b/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs
index 5b20d770d9ba..3f2134cb37d5 100644
--- a/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs
+++ b/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs
@@ -97,6 +97,8 @@ public partial class HubConnection : IAsyncDisposable
/// If this event was triggered from a connection error, the that occurred will be passed in as the
/// sole argument to this handler. If this event was triggered intentionally by either the client or server, then
/// the argument will be .
+ ///
+ /// The result is fire-and-forget: the does not wait for it to complete.
///
///
/// The following example attaches a handler to the event, and checks the provided argument to determine
@@ -123,6 +125,8 @@ public partial class HubConnection : IAsyncDisposable
///
///
/// The that occurred will be passed in as the sole argument to this handler.
+ ///
+ /// The result is fire-and-forget: the does not wait for it to complete.
///
///
/// The following example attaches a handler to the event, and checks the provided argument to log the error.
@@ -141,6 +145,8 @@ public partial class HubConnection : IAsyncDisposable
///
///
/// The parameter will be the 's new ConnectionId or null if negotiation was skipped.
+ ///
+ /// The result is fire-and-forget: the does not wait for it to complete.
///
///
/// The following example attaches a handler to the event, and checks the provided argument to log the ConnectionId.
From 87f954aef196d45f3fe5952aeaf0ede4b1cf3e61 Mon Sep 17 00:00:00 2001
From: Smaug123 <3138005+Smaug123@users.noreply.github.com>
Date: Mon, 20 Jan 2025 18:34:10 +0000
Subject: [PATCH 2/2] Stop using exact words fire-and-forget
---
src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs b/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs
index f6c356549589..1d298f5d63fe 100644
--- a/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs
+++ b/src/SignalR/clients/csharp/Client.Core/src/HubConnection.cs
@@ -98,7 +98,7 @@ public partial class HubConnection : IAsyncDisposable
/// sole argument to this handler. If this event was triggered intentionally by either the client or server, then
/// the argument will be .
///
- /// The result is fire-and-forget: the does not wait for it to complete.
+ /// The result does not block operations.
///
///
/// The following example attaches a handler to the event, and checks the provided argument to determine
@@ -126,7 +126,7 @@ public partial class HubConnection : IAsyncDisposable
///
/// The that occurred will be passed in as the sole argument to this handler.
///
- /// The result is fire-and-forget: the does not wait for it to complete.
+ /// The result does not block operations.
///
///
/// The following example attaches a handler to the event, and checks the provided argument to log the error.
@@ -146,7 +146,7 @@ public partial class HubConnection : IAsyncDisposable
///
/// The parameter will be the 's new ConnectionId or null if negotiation was skipped.
///
- /// The result is fire-and-forget: the does not wait for it to complete.
+ /// The result does not block operations.
///
///
/// The following example attaches a handler to the event, and checks the provided argument to log the ConnectionId.