From 44da57ce9c296d3cdb80c25c7709afb8f1255e7f Mon Sep 17 00:00:00 2001 From: Mike Kistler Date: Tue, 11 Jun 2024 12:40:16 -0700 Subject: [PATCH 1/3] Minor doc fix --- .../src/IAuthenticationHandler.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs b/src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs index 7b5287ddfdb2..f477542e1067 100644 --- a/src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs +++ b/src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs @@ -18,19 +18,19 @@ public interface IAuthenticationHandler Task InitializeAsync(AuthenticationScheme scheme, HttpContext context); /// - /// Authenticate the current request. + /// Authenticate the request associated with the passed to the InitializeAsync method. /// /// The result. Task AuthenticateAsync(); /// - /// Challenge the current request. + /// Challenge the request associated with the passed to the InitializeAsync method. /// /// The that contains the extra meta-data arriving with the authentication. Task ChallengeAsync(AuthenticationProperties? properties); /// - /// Forbid the current request. + /// Forbid the request associated with the passed to the InitializeAsync method. /// /// The that contains the extra meta-data arriving with the authentication. Task ForbidAsync(AuthenticationProperties? properties); From df4b87257a343e391494fb715635f9e0497233ac Mon Sep 17 00:00:00 2001 From: Mike Kistler Date: Wed, 12 Jun 2024 09:53:44 -0700 Subject: [PATCH 2/3] Apply suggestions from code review Co-authored-by: Stephen Halter --- .../src/IAuthenticationHandler.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs b/src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs index f477542e1067..89ce2ef78e02 100644 --- a/src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs +++ b/src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs @@ -18,19 +18,19 @@ public interface IAuthenticationHandler Task InitializeAsync(AuthenticationScheme scheme, HttpContext context); /// - /// Authenticate the request associated with the passed to the InitializeAsync method. + /// Authenticate the current request using the passed to the method. /// /// The result. Task AuthenticateAsync(); /// - /// Challenge the request associated with the passed to the InitializeAsync method. + /// Challenge the current request using the passed to the method. /// /// The that contains the extra meta-data arriving with the authentication. Task ChallengeAsync(AuthenticationProperties? properties); /// - /// Forbid the request associated with the passed to the InitializeAsync method. + /// Forbid the current request using the passed to the method. /// /// The that contains the extra meta-data arriving with the authentication. Task ForbidAsync(AuthenticationProperties? properties); From b62f4a8c338cf58bfc3330b66a03fdfe154bbe0d Mon Sep 17 00:00:00 2001 From: Mike Kistler Date: Wed, 12 Jun 2024 09:56:54 -0700 Subject: [PATCH 3/3] simpler fix --- .../src/IAuthenticationHandler.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs b/src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs index 89ce2ef78e02..4f2168c5b18a 100644 --- a/src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs +++ b/src/Http/Authentication.Abstractions/src/IAuthenticationHandler.cs @@ -14,23 +14,23 @@ public interface IAuthenticationHandler /// Initialize the authentication handler. The handler should initialize anything it needs from the request and scheme as part of this method. /// /// The scheme. - /// The context. + /// The context for the current request. Task InitializeAsync(AuthenticationScheme scheme, HttpContext context); /// - /// Authenticate the current request using the passed to the method. + /// Authenticate the current request. /// /// The result. Task AuthenticateAsync(); /// - /// Challenge the current request using the passed to the method. + /// Challenge the current request. /// /// The that contains the extra meta-data arriving with the authentication. Task ChallengeAsync(AuthenticationProperties? properties); /// - /// Forbid the current request using the passed to the method. + /// Forbid the current request. /// /// The that contains the extra meta-data arriving with the authentication. Task ForbidAsync(AuthenticationProperties? properties);