Throw if the default key is revoked #54278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under somewhat contrived circumstances, it's possible that the keyring, on determining that no suitable default key is available, will generate a new, immediately-activated key and that that key will also be immediately-revoked. For example, it's possible to revoke all keys created before a given date and clock skew between servers could result in that being in the future for some servers. It's also possible that a third-party `IDefaultKeyResolver` could select a revoked key, since the contract doesn't state that it should not. Having said that, we haven't really hardened against other misbehavior by resolvers, so this isn't terribly compelling. Still, no harm in throwing - better than using a revoked key to encrypt data.
captainsafia
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under somewhat contrived circumstances, it's possible that the keyring, on determining that no suitable default key is available, will generate a new, immediately-activated key and that that key will also be immediately-revoked. For example, it's possible to revoke all keys created before a given date and clock skew between servers could result in that being in the future for some servers.
It's also possible that a third-party
IDefaultKeyResolvercould select a revoked key, since the contract doesn't state that it should not. Having said that, we haven't really hardened against other misbehavior by resolvers, so this isn't terribly compelling.Still, no harm in throwing - better than using a revoked key to encrypt data.