-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add feature to expose IIS hosting details #50128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@adityamandaleeka, @BrennanConroy, can you check the native code and merge? |
src/Servers/IIS/AspNetCoreModuleV2/AspNetCore/ModuleEnvironment.cpp
Outdated
Show resolved
Hide resolved
BrennanConroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test?
This looks similar to what we would add:
aspnetcore/src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestResponseTests.cs
Line 605 in 9402bfa
| public async Task HostingEnvironmentIsCorrect() |
BrennanConroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test 👍
Now you just need to make it work for both IISExpress and IIS 😉
|
Native parts look fine to me. Maybe a bit too much |
|
@BrennanConroy got it working for both IISExpress and IIS. Had to surface some data from the deployer to be able to test the resulting values @adityamandaleeka I've replaced |
|
Thanks @twsouthwick |
|
/backport to release/8.0 |
|
Hi @twsouthwick. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/6030166080 |
Adds IIISEnvironmentFeature to expose IIS hosting details. This makes the following changes:
aspnetcorev2.dllto set environment variables for IIS values we needIIISEnvironmentFeatureviaIServer.Featureson IIS if the values are availableFixes #43632