-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Remove rules associated with the auto-merge label #48227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This label has been removed as part of the effort to clean-up the labels in the repo. So these rules don't work anymore. During the conversation with some team members it sounded like the current behavior is preferable.
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
|
Not exactly related but what about |
|
Same question for task |
joperezr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small question regarding two other tasks, but otherwise this looks good, thanks @mkArtakMSFT!
There was a reason we did this in the first place. Do we have reasons to believe that we should back up on this decision? |
|
I'm assuming the reason might have been that in order for dependency flow PRs to get auto merged they required an approval? If that's the case, now that we are removing the auto-merge capability for those, then it probably makes sense to also remove the auto-approval. |
|
Let's see what @wtgodbe has to say about this. |
|
I think it's fine to keep the auto-approval, that keeps the build-ops person's task more mechanical (check the PR is green, merge the PR). And I like keeping the auto-label for them too, it's accurate. |
|
@joperezr I'm merging this change as is. I'm happy to continue the conversation and if we decide that more rules should be removed, I'd send another PR out. |
This label has been removed as part of the effort to clean-up the labels in the repo. So these rules don't work anymore. During the conversation with some team members, it sounded like the current behavior is preferable.