From e2c7ba2167292b2b060f9deb8d0f180d7b6abfd4 Mon Sep 17 00:00:00 2001 From: Surayya Huseyn Zada Date: Mon, 24 Apr 2023 12:11:52 +0200 Subject: [PATCH] changed behavior of anchor tag with href starting with hash --- src/Components/Web.JS/src/Services/NavigationManager.ts | 4 ---- src/Components/test/E2ETest/Tests/RoutingTest.cs | 4 ++-- .../BasicTestApp/RouterTest/LongPageWithHash.razor | 8 ++++---- 3 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/Components/Web.JS/src/Services/NavigationManager.ts b/src/Components/Web.JS/src/Services/NavigationManager.ts index a30f9687542f..add7e582a3c8 100644 --- a/src/Components/Web.JS/src/Services/NavigationManager.ts +++ b/src/Components/Web.JS/src/Services/NavigationManager.ts @@ -90,10 +90,6 @@ export function attachToEventDelegator(eventDelegator: EventDelegator): void { if (anchorTarget && canProcessAnchor(anchorTarget)) { let anchorHref = anchorTarget.getAttribute('href')!; - if (anchorHref.startsWith('#')) { - // Preserve the existing URL but set the hash to match the link that was clicked - anchorHref = `${location.origin}${location.pathname}${location.search}${anchorHref}`; - } const absoluteHref = toAbsoluteUri(anchorHref); diff --git a/src/Components/test/E2ETest/Tests/RoutingTest.cs b/src/Components/test/E2ETest/Tests/RoutingTest.cs index 8bdfb75eaa35..a2f0ac001d3f 100644 --- a/src/Components/test/E2ETest/Tests/RoutingTest.cs +++ b/src/Components/test/E2ETest/Tests/RoutingTest.cs @@ -1547,7 +1547,7 @@ public void CanNavigateBetweenPagesWithQueryStrings() } [Fact] - public void AnchorWithHrefStartingWithHash_ScrollsToElementWithIdOnTheSamePage() + public void AnchorWithHrefContainingHashSamePage_ScrollsToElementWithIdOnTheSamePage() { SetUrlViaPushState("/"); var app = Browser.MountTestComponent(); @@ -1563,7 +1563,7 @@ public void AnchorWithHrefStartingWithHash_ScrollsToElementWithIdOnTheSamePage() } [Fact] - public void AnchorWithHrefContainingHash_NavigatesToPageAndScrollsToElementWithName() + public void AnchorWithHrefContainingHashAnotherPage_NavigatesToPageAndScrollsToElementWithName() { SetUrlViaPushState("/"); var app = Browser.MountTestComponent(); diff --git a/src/Components/test/testassets/BasicTestApp/RouterTest/LongPageWithHash.razor b/src/Components/test/testassets/BasicTestApp/RouterTest/LongPageWithHash.razor index 6de0c230a348..c34d8e2e8f36 100644 --- a/src/Components/test/testassets/BasicTestApp/RouterTest/LongPageWithHash.razor +++ b/src/Components/test/testassets/BasicTestApp/RouterTest/LongPageWithHash.razor @@ -1,9 +1,9 @@ @page "/LongPageWithHash" @inject NavigationManager NavigationManager -Go to test1 on this page +Go to test1 on this page
-Go to test2 on LongPageWithHash2 page +Go to test2 on LongPageWithHash2 page

@@ -22,11 +22,11 @@ @code { void GoToTest1() { - NavigationManager.NavigateTo("/subdir/LongPageWithHash#test1"); + NavigationManager.NavigateTo("LongPageWithHash#test1"); } void GoToTest2() { - NavigationManager.NavigateTo("/subdir/LongPageWithHash2#test2"); + NavigationManager.NavigateTo("LongPageWithHash2#test2"); } }