Sections support #46727

surayya-MS · 2023-02-17T17:16:48Z

Sections support

You've read the Contributor Guide and Code of Conduct.
You've included unit or integration tests for your change, where applicable.
You've included inline docs for your change, where applicable.
There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

API Proposal: #46937

Description

Made SectionContent and SectionOutlet public
Removed SectionContent.IsDefaultContent
Removed Name and used object SectionId as a section identifier
Added E2E tests for Sections

Fixes #28182

src/Components/test/testassets/BasicTestApp/BasicTestApp.csproj

src/Components/Web/src/Head/HeadOutlet.cs

src/Components/test/E2ETest/Tests/SectionsTest.cs

src/Components/test/testassets/BasicTestApp/SectionsTest/ParentComponent.razor

src/Components/test/E2ETest/Tests/SectionsTest.cs

src/Components/test/testassets/BasicTestApp/SectionsTest/ParentComponentWithTwoChildren.razor

src/Components/test/E2ETest/Tests/SectionsTest.cs

MackinnonBuck

This is looking great! I just added a few more comments with some minor thoughts.

Before approving, I would still like to see what others think about this suggestion.

src/Components/test/testassets/BasicTestApp/SectionsTest/ParentComponentWithTwoChildren.razor

src/Components/test/E2ETest/Tests/SectionsTest.cs

src/Components/Components/src/Sections/SectionOutlet.cs

src/Components/Components/src/Sections/SectionContent.cs

src/Components/Web/src/Head/HeadOutlet.cs

Co-authored-by: Mackinnon Buck <[email protected]>

MackinnonBuck

This is looking great 🎉 Thank you for your perseverance on this!

I have a few remaining nits but nothing that should block the approval of this PR. I think this is ready to go after all tests pass (and the API gets approved).

src/Components/Components/src/Sections/SectionContent.cs

src/Components/Components/src/Sections/SectionOutlet.cs

src/Components/Components/src/Sections/SectionRegistry.cs

src/Components/Web/src/Head/HeadOutlet.cs

src/Components/test/E2ETest/Tests/SectionsTest.cs

src/Components/test/testassets/BasicTestApp/SectionsTest/ParentComponentWithTwoChildren.razor

Co-authored-by: Mackinnon Buck <[email protected]>

…tcore into sectionsSupport

src/Components/Components/src/PublicAPI.Unshipped.txt

This reverts commit 48538d1.

This reverts commit 4b92f0c.

surayya-MS added 2 commits February 17, 2023 17:15

sections support

89c686d

change SecionsTest

7e99bde

surayya-MS requested a review from a team as a code owner February 17, 2023 17:16

ghost added the area-blazor Includes: Blazor, Razor Components label Feb 17, 2023

surayya-MS requested a review from MackinnonBuck February 17, 2023 17:17

MackinnonBuck reviewed Feb 17, 2023

View reviewed changes

src/Components/test/testassets/BasicTestApp/BasicTestApp.csproj Outdated Show resolved Hide resolved

src/Components/Web/src/Head/HeadOutlet.cs Outdated Show resolved Hide resolved

fix

cbb63aa

MackinnonBuck reviewed Feb 17, 2023

View reviewed changes

src/Components/test/E2ETest/Tests/SectionsTest.cs Outdated Show resolved Hide resolved

src/Components/test/testassets/BasicTestApp/SectionsTest/ParentComponent.razor Outdated Show resolved Hide resolved

src/Components/test/E2ETest/Tests/SectionsTest.cs Show resolved Hide resolved

build-analysis bot mentioned this pull request Feb 17, 2023

Request failed "500 Internal Server Error" dotnet/arcade#11737

Open

5 tasks

Nick-Stanton reviewed Feb 17, 2023

View reviewed changes

src/Components/test/E2ETest/Tests/SectionsTest.cs Show resolved Hide resolved

surayya-MS added 2 commits February 20, 2023 13:02

use Browser.Exists in tests; move code block to the end of .razor file

397b91a

E2E tests

0e7d9c5

MackinnonBuck reviewed Feb 21, 2023

View reviewed changes

src/Components/test/testassets/BasicTestApp/SectionsTest/ParentComponentWithTwoChildren.razor Outdated Show resolved Hide resolved

src/Components/test/E2ETest/Tests/SectionsTest.cs Show resolved Hide resolved

surayya-MS added 2 commits February 21, 2023 21:36

use private fields for buttons in tests; use "-" instead of "_" fir ids

269b8d4

support changing IsDefaultContent; fix tests

85f3a7c

surayya-MS mentioned this pull request Feb 22, 2023

E2E tests WebDriverExtensions.Navigate argument noReload has no effect #46810

Closed

MackinnonBuck reviewed Feb 22, 2023

View reviewed changes

surayya-MS and others added 5 commits February 23, 2023 10:12

fix

ebca897

Merge branch 'main' into sectionsSupport

32fb842

use object SectionId instead of string Name

85b8ec6

fix

435716a

Merge branch 'main' into sectionsSupport

4cca921

MackinnonBuck reviewed Feb 23, 2023

View reviewed changes

surayya-MS and others added 2 commits February 24, 2023 11:59

Update src/Components/Components/src/Sections/SectionContent.cs

c42520a

Co-authored-by: Mackinnon Buck <[email protected]>

fix

d3352be

MackinnonBuck approved these changes Feb 28, 2023

View reviewed changes

surayya-MS and others added 4 commits March 1, 2023 09:49

Update src/Components/test/E2ETest/Tests/SectionsTest.cs

495bff4

Co-authored-by: Mackinnon Buck <[email protected]>

Update src/Components/Web/src/Head/HeadOutlet.cs

4742a2d

Co-authored-by: Mackinnon Buck <[email protected]>

Update src/Components/Components/src/Sections/SectionOutlet.cs

7323ca1

Co-authored-by: Mackinnon Buck <[email protected]>

Update src/Components/Components/src/Sections/SectionContent.cs

b7be8b4

Co-authored-by: Mackinnon Buck <[email protected]>

surayya-MS and others added 4 commits March 1, 2023 10:02

Update src/Components/Components/src/Sections/SectionOutlet.cs

cb0d2e3

Co-authored-by: Mackinnon Buck <[email protected]>

fix

52bc8d9

Merge branch 'sectionsSupport' of https://github.com/surayya-MS/aspne…

e21ae58

…tcore into sectionsSupport

fix

ae3171e

SteveSandersonMS reviewed Mar 2, 2023

View reviewed changes

src/Components/Components/src/PublicAPI.Unshipped.txt Outdated Show resolved Hide resolved

surayya-MS added 6 commits March 6, 2023 11:17

fix

35d13b9

change exceptions messages in SectionRegistry

275100b

remove IsDefaultContent from SectionContent

4b92f0c

remove IsDefaultContent from PublicAPI

48538d1

Merge branch 'main' into sectionsSupport

08ebe15

fix

e418aa6

surayya-MS enabled auto-merge (squash) March 6, 2023 19:26

Merge branch 'main' into sectionsSupport

853e6ea

surayya-MS disabled auto-merge March 7, 2023 14:40

surayya-MS added 5 commits March 7, 2023 16:14

Revert "remove IsDefaultContent from PublicAPI"

157bdaf

This reverts commit 48538d1.

Revert "remove IsDefaultContent from SectionContent"

036dc2d

This reverts commit 4b92f0c.

made IsDefaultContent internal

a6ef091

Merge branch 'main' into sectionsSupport

403d493

fix

b1b8be8

surayya-MS enabled auto-merge (squash) March 8, 2023 16:22

surayya-MS merged commit 83dad2c into dotnet:main Mar 8, 2023

ghost added this to the 8.0-preview3 milestone Mar 8, 2023

guardrex mentioned this pull request Mar 8, 2023

Blazor .NET 8 tracking issue dotnet/AspNetCore.Docs#28161

Closed

surayya-MS deleted the sectionsSupport branch May 15, 2023 14:38

Sections support #46727

Sections support #46727

Uh oh!

Conversation

surayya-MS commented Feb 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sections support

Description

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MackinnonBuck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MackinnonBuck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

surayya-MS commented Feb 17, 2023 •

edited

Loading