Change build components to C++ Win10 17134 SDK #4603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
approved these changes
Dec 12, 2018
Contributor
natemcmaster
left a comment
natemcmaster
left a comment
There was a problem hiding this comment.
LGTM. Wait until TeamCity is up to date, of course, then 
Contributor
Author
|
I'm shocked our AzureDevOps agents have the component too 😄 |
JamesNK
approved these changes
Dec 12, 2018
Contributor
|
It looks like the dnceng build queues don't have this yet. https://github.com/dotnet/core-eng/issues/4764. We haven't started using those queues yet, so it's okay to merge this. |
Contributor
Author
|
Going to put out other IIS test fires before starting a new one by merging this. |
jkotalik
force-pushed
the
jkotalik/installVSScript
branch
from
3caa2d8 to
3947104
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/aspnet/AspNetCore-Internal/issues/1505. 15063 doesn't exist on VS16.0 (VS2019).
This will conflict with #4311; I'm opening this to find any build issues primarily.