Skip to content

[release/6.0] Work around #41937 and stop skipping tests #42139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 11, 2022
Merged

[release/6.0] Work around #41937 and stop skipping tests #42139

merged 2 commits into from
Jun 11, 2022

Conversation

@dougbu
Copy link
Contributor

@dougbu dougbu commented Jun 10, 2022

[release/6.0] Work around #41937

  • unset ASPNETCORE_ENVIRONMENT on Helix agents

[release/6.0] Undo #41937 changes

dougbu added 2 commits June 10, 2022 15:39
@dougbu
[release/6.0] Work around #41937
c11f319 
- unset `ASPNETCORE_ENVIRONMENT` on Helix agents
@dougbu
[release/6.0] Undo #41937 changes
ae09594 
- tests look green with workaround in place
- partially revert "Update branding to 6.0.7 (#42078)"
- was commit 78f64d8
@dougbu dougbu requested review from a team, Pilchie and javiercn as code owners June 10, 2022 23:14
@ghost ghost added this to the 6.0.x milestone Jun 10, 2022
@ghost
Copy link

ghost commented Jun 10, 2022

Hi @dougbu. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@dougbu dougbu mentioned this pull request Jun 10, 2022
Closed
@dougbu dougbu enabled auto-merge June 10, 2022 23:19
@dougbu
Copy link
Contributor Author

dougbu commented Jun 10, 2022

Enabled auto-merge. Will use an actual merge to keep the revert part separate.

@dougbu dougbu added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode labels Jun 10, 2022
@ghost
Copy link

ghost commented Jun 10, 2022

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@dougbu
Copy link
Contributor Author

dougbu commented Jun 10, 2022

/fyi this is tell-mode because I'm touching only test-related bits

@dougbu dougbu merged commit bd44d90 into dotnet:release/6.0 Jun 11, 2022
@dougbu dougbu deleted the dougbu/reenable.tests.41937/6.0 branch June 11, 2022 01:40
@dougbu dougbu modified the milestones: 6.0.x, 6.0.7 Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoK HaoK HaoK approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@MattGal MattGal Awaiting requested review from MattGal

@MackinnonBuck MackinnonBuck Awaiting requested review from MackinnonBuck

@javiercn javiercn Awaiting requested review from javiercn

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode

Projects

None yet

Milestone

6.0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@dougbu @HaoK @wtgodbe