Skip to content

Remove unused code from ANCM setup and enable more MSVC warnings for SDL #41747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 19, 2022
Merged

Remove unused code from ANCM setup and enable more MSVC warnings for SDL #41747

merged 3 commits into from
May 19, 2022

Conversation

@adityamandaleeka
Copy link
Member

@adityamandaleeka adityamandaleeka commented May 19, 2022

This covers the installers part of #40525

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 19, 2022
@adityamandaleeka
Copy link
Member Author

adityamandaleeka commented May 19, 2022

Leaving this as draft to see if it causes any issues. If it's good we can get rid of the unnecessary copies of these files.

@adityamandaleeka adityamandaleeka marked this pull request as ready for review May 19, 2022 18:47
@adityamandaleeka adityamandaleeka requested a review from Pilchie as a code owner May 19, 2022 18:47
@adityamandaleeka
Copy link
Member Author

adityamandaleeka commented May 19, 2022

Looks like this checks out. I'll push an update that removes the unused files.

@adityamandaleeka
Copy link
Member Author

adityamandaleeka commented May 19, 2022

@wtgodbe I'd like to get your review on this too.

wtgodbe
wtgodbe approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the comment

@adityamandaleeka adityamandaleeka enabled auto-merge (squash) May 19, 2022 20:17
@adityamandaleeka adityamandaleeka disabled auto-merge May 19, 2022 20:22
@adityamandaleeka adityamandaleeka enabled auto-merge (squash) May 19, 2022 20:26
@adityamandaleeka adityamandaleeka merged commit 9a81d79 into dotnet:main May 19, 2022
@ghost ghost added this to the 7.0-preview5 milestone May 19, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoK HaoK HaoK approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

7.0-preview5

Development

Successfully merging this pull request may close these issues.

4 participants

@adityamandaleeka @HaoK @wtgodbe @amcasey