Allow HttpSys zero-byte reads #41500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow HttpSys zero-byte reads
Allow zero length reads from the Http.Sys request body stream
Description
AspNetCore and YARP have started to take advantage of the zero-byte-read pattern, where zero length buffers are passed to read operations to be notified when data is available. This allows the caller to avoid allocations and pinning on slow/idle streams like gRPC and WebSockets.
The Http.Sys server request body stream does not currently allow this. First, it performs argument checks that disallow a zero length buffer. Also, when the native read completes it returns ERROR_MORE_DATA rather than SUCCESS. This needs to be handled by the stream or it will throw an IOException.
Fixes #41305
Customer Impact
Since YARP 1.1 adopted the zero-byte-read pattern for performance reasons customers can no longer use it with our Http.Sys server.
Regression?
Risk
Verification
Packaging changes reviewed?