Annotate Microsoft.AspNetCore.Routing for trimming #40974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
pranavkm
requested review from
a team,
BrennanConroy,
JamesNK,
Pilchie,
Tratcher,
dougbu,
halter73,
javiercn and
wtgodbe
as code owners
TanayParikh
reviewed
Mar 31, 2022
JamesNK
reviewed
Mar 31, 2022
Member
There was a problem hiding this comment.
object values, look what you've done 😢
Member
* Connections.Abstractions * Microsoft.AspNetCore.Http * Microsoft.AspNetCore.Http.Routing
pranavkm
force-pushed
the
routing-trimmer
branch
from
d14426e to
30b889c
Compare
pranavkm
changed the title
JamesNK
approved these changes
Apr 7, 2022
dougbu
reviewed
Apr 7, 2022
| /// names from <c>RouteOptions</c>. | ||
| /// </param> | ||
| /// <returns>A URI with an absolute path, or <c>null</c>.</returns> | ||
| [SuppressMessage("ApiDesign", "RS0026:Do not add multiple public overloads with optional parameters", Justification = "Required to maintain compatibility")] |
Contributor
There was a problem hiding this comment.
This is a new overload. How is it "Required to maintain compatibility"❔ Same for a few other new overloads in this class.
Member
There was a problem hiding this comment.
I believe that message is used because it needs to be placed on both the old and new methods.
The same message is used when suppressing all warnings of this type - https://github.com/dotnet/aspnetcore/search?p=1&q=RS0026
src/Servers/Connections.Abstractions/src/Microsoft.AspNetCore.Connections.Abstractions.csproj
Show resolved
Hide resolved
Co-authored-by: Doug Bunting <[email protected]>
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.