Skip to content

Enable more MSVC warnings for SDL signoff #40777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2022
Merged

Enable more MSVC warnings for SDL signoff #40777

merged 3 commits into from
Mar 21, 2022

Conversation

@adityamandaleeka
Copy link
Member

@adityamandaleeka adityamandaleeka commented Mar 18, 2022

Fix #40525

@ghost ghost added the area-runtime label Mar 18, 2022
HaoK
HaoK reviewed Mar 18, 2022
View reviewed changes
@HaoK
Copy link
Member

HaoK commented Mar 18, 2022 •
edited
Loading

Do we also need to do this for the installer CAs? i.e. the vcxproj for aspnetca/iisca and the random other ones under https://github.com/dotnet/aspnetcore/tree/main/src/Installers/Windows

@adityamandaleeka
Copy link
Member Author

adityamandaleeka commented Mar 18, 2022 •
edited
Loading

Do we also need to do this for the installer CAs? i.e. the vcxproj for aspnetca/iisca and the random other ones under https://github.com/dotnet/aspnetcore/tree/main/src/Installers/Windows

Good call, yea, I think so. Will do that in a separate PR.

@adityamandaleeka
Copy link
Member Author

adityamandaleeka commented Mar 19, 2022

I think we should keep these commits separate FWIW so we can easily separate the SDL warning changes and the IISLib cleanup if needed in the future.

HaoK
HaoK reviewed Mar 19, 2022
View reviewed changes
HaoK
HaoK reviewed Mar 19, 2022
View reviewed changes
HaoK
HaoK reviewed Mar 19, 2022
View reviewed changes
src/Servers/IIS/AspNetCoreModuleV2/IISLib/stringa.cpp
if( !m_Buff.Resize( static_cast<SIZE_T>(cbNeeded) ) )
{
hr = E_OUTOFMEMORY;
goto Finished;
Copy link
Member

@HaoK HaoK Mar 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow gotos!

Copy link
Member

@GrabYourPitchforks GrabYourPitchforks Mar 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes it's C code spiffed up in a .cpp file extension. :)

@adityamandaleeka adityamandaleeka merged commit 57c3104 into dotnet:main Mar 21, 2022
@ghost ghost added this to the 7.0-preview3 milestone Mar 21, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks left review comments

@HaoK HaoK HaoK approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

7.0-preview3

Development

Successfully merging this pull request may close these issues.

SDL signoff requirements - please enable additional C/C++ compiler warnings

4 participants

@adityamandaleeka @HaoK @GrabYourPitchforks @amcasey