[release/6.0] [SignalR] Only minify .min.js files #39859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
BrennanConroy and
halter73
as code owners
ghost
added
the
|
Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
halter73
approved these changes
Jan 31, 2022
BrennanConroy
added
the
Servicing-consider
|
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
leecow
added
Servicing-approved
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #39842 to release/6.0
/cc @BrennanConroy
Description
The building of the SignalR javascript browser files was refactored in 6.0 and generates two files, one minified for lowering webpage bandwidth and one non-minified for readability and dev time debugging. The non-minified file was accidentally being generated as a minified file.
Fixes #39829
Customer Impact
Customers aren't seeing the readable javascript file during development which can hinder their development efforts.
Regression?
Regressed from 5.0 to 6.0
Risk
Only affects non-minified javascript files, manually verified both minified and non-minified files work as expected
Verification
Packaging changes reviewed?