[SignalR] Only minify .min.js files #39842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
approved these changes
Jan 28, 2022
Member
halter73
left a comment
halter73
left a comment
There was a problem hiding this comment.
Is there good way to regression test this?
Member
I agree we should do this. |
Member
Author
I wrote a test for this, check it out. |
ghost
added this to the
Member
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1764872876 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39829
Our webpack configuration handles calling terser so there is no need for an extra build step that manually calls terser. Additionally, added multiple outputs to the webpack config so we can run minify on only the
.min.jsfiles.We might want to consider backporting this to 6.0 since the non-minified file regressed in 6.0 to ship as minified.