Skip to content

Unquarantine tests #39659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Unquarantine tests #39659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
daa5856
Less iterations
HaoK Jan 20, 2022
e035855
Parole
HaoK Jan 20, 2022
6f1d1f4
Parole
HaoK Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Servers/HttpSys/test/FunctionalTests/Listener/RequestBodyTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ namespace Microsoft.AspNetCore.Server.HttpSys.Listener;
public class RequestBodyTests
{
[ConditionalFact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27399")]
Copy link
Contributor

@dougbu dougbu Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this test an un-quarantine candidate❔ There's no record of a fix.

public async Task RequestBody_SyncReadDisabledByDefault_WorksWhenEnabled()
{
string address;
Expand Down
4 changes: 1 addition & 3 deletions src/Servers/IIS/IIS/test/Common.FunctionalTests/RequestResponseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,12 +156,10 @@ public async Task PassesThroughCompressionInProcess()
}

[ConditionalFact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/26294")]
[SkipNonHelix("This test takes 5 minutes to run")]
Copy link
Contributor

@dougbu dougbu Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running successfully 💯% of the time isn't sufficient reason to un-quarantine. Does the following apply (from the doc)❔

Find the set of tests that were supposedly fixed at least 30 days ago.

public async Task ReadAndWriteSynchronously()
{
var content = new StringContent(new string('a', 100000));
for (int i = 0; i < 500; i++)
for (int i = 0; i < 50; i++)
Copy link
Member

@wtgodbe wtgodbe Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why fewer iterations?

{
var response = await _fixture.Client.PostAsync("ReadAndWriteSynchronously", content);
var responseText = await response.Content.ReadAsStringAsync();
Expand Down
1 change: 0 additions & 1 deletion src/Servers/IIS/IIS/test/IIS.Tests/ClientDisconnectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,6 @@ public async Task ReaderThrowsCanceledException()
}

[ConditionalFact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/27400")]
Copy link
Contributor

@dougbu dougbu Jan 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue was also never marked as test-fixed

public async Task ReaderThrowsResetExceptionOnInvalidBody()
{
var requestStartedCompletionSource = CreateTaskCompletionSource();
Expand Down