Skip to content

Quarantine BlazorWasmHostedTemplate_AzureActiveDirectoryTemplate_Works #37783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2021
Merged

Quarantine BlazorWasmHostedTemplate_AzureActiveDirectoryTemplate_Works #37783

merged 1 commit into from
Oct 23, 2021

Conversation

@sebastienros
Copy link
Member

@sebastienros sebastienros commented Oct 22, 2021

@sebastienros sebastienros requested a review from Pilchie as a code owner October 22, 2021 23:09
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Oct 22, 2021
@TanayParikh TanayParikh requested a review from a team October 23, 2021 05:59
TanayParikh
TanayParikh suggested changes Oct 23, 2021
View reviewed changes
Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

error : The file '/tmp/helix/working/A97408FB/w/9C9608B1/e/Templates/BaseFolder/AspNet.jjso4iuzrzq/Client/obj/project.nuget.cache' already exists.

Looks like an infra issue, I don't believe this needs quarantining.

@sebastienros
Copy link
Member Author

sebastienros commented Oct 23, 2021

It's not "flaky", but I think it should still be quarantined until fixed. Builds are failing because of that, and the test is useless as it's a duplicate of E2E tests (all Playwright ones AFAIK).

@HaoK
Copy link
Member

HaoK commented Oct 23, 2021

Yeah this one is failing too much to keep around

@TanayParikh TanayParikh merged commit d66da1f into main Oct 23, 2021
@TanayParikh TanayParikh deleted the sebros/qp branch October 23, 2021 18:20
@ghost ghost added this to the 7.0-preview1 milestone Oct 23, 2021
@TanayParikh TanayParikh mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaoK HaoK HaoK approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

+1 more reviewer

@TanayParikh TanayParikh TanayParikh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates

Projects

None yet

Milestone

7.0-preview1

Development

Successfully merging this pull request may close these issues.

4 participants

@sebastienros @HaoK @TanayParikh