From 2f91cc821eaf8d617a95898b2c7a9ef6e32c8209 Mon Sep 17 00:00:00 2001 From: Will Godbe Date: Thu, 21 Oct 2021 13:07:01 -0700 Subject: [PATCH] Unquarantine (most) HTTP3 tests --- .../Kestrel/Transport.Quic/test/QuicConnectionContextTests.cs | 1 - .../Kestrel/Transport.Quic/test/QuicConnectionListenerTests.cs | 1 - .../Kestrel/Transport.Quic/test/QuicStreamContextTests.cs | 1 - .../Kestrel/Transport.Quic/test/QuicTransportFactoryTests.cs | 1 - src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs | 1 - .../test/Interop.FunctionalTests/Http3/Http3RequestTests.cs | 3 ++- .../test/Interop.FunctionalTests/Http3/Http3TlsTests.cs | 3 ++- 7 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/Servers/Kestrel/Transport.Quic/test/QuicConnectionContextTests.cs b/src/Servers/Kestrel/Transport.Quic/test/QuicConnectionContextTests.cs index ed038f476f8b..b341d5d11f9c 100644 --- a/src/Servers/Kestrel/Transport.Quic/test/QuicConnectionContextTests.cs +++ b/src/Servers/Kestrel/Transport.Quic/test/QuicConnectionContextTests.cs @@ -13,7 +13,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Quic.Tests { - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35070")] public class QuicConnectionContextTests : TestApplicationErrorLoggerLoggedTest { private static readonly byte[] TestData = Encoding.UTF8.GetBytes("Hello world"); diff --git a/src/Servers/Kestrel/Transport.Quic/test/QuicConnectionListenerTests.cs b/src/Servers/Kestrel/Transport.Quic/test/QuicConnectionListenerTests.cs index f9ba0e09c35c..39b15fc8ae5d 100644 --- a/src/Servers/Kestrel/Transport.Quic/test/QuicConnectionListenerTests.cs +++ b/src/Servers/Kestrel/Transport.Quic/test/QuicConnectionListenerTests.cs @@ -14,7 +14,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Quic.Tests { - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35070")] public class QuicConnectionListenerTests : TestApplicationErrorLoggerLoggedTest { private static readonly byte[] TestData = Encoding.UTF8.GetBytes("Hello world"); diff --git a/src/Servers/Kestrel/Transport.Quic/test/QuicStreamContextTests.cs b/src/Servers/Kestrel/Transport.Quic/test/QuicStreamContextTests.cs index cf23fe5566cf..fa82b396b22e 100644 --- a/src/Servers/Kestrel/Transport.Quic/test/QuicStreamContextTests.cs +++ b/src/Servers/Kestrel/Transport.Quic/test/QuicStreamContextTests.cs @@ -19,7 +19,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Quic.Tests { - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35070")] public class QuicStreamContextTests : TestApplicationErrorLoggerLoggedTest { private static readonly byte[] TestData = Encoding.UTF8.GetBytes("Hello world"); diff --git a/src/Servers/Kestrel/Transport.Quic/test/QuicTransportFactoryTests.cs b/src/Servers/Kestrel/Transport.Quic/test/QuicTransportFactoryTests.cs index 6299ec64617c..d7a952cf605c 100644 --- a/src/Servers/Kestrel/Transport.Quic/test/QuicTransportFactoryTests.cs +++ b/src/Servers/Kestrel/Transport.Quic/test/QuicTransportFactoryTests.cs @@ -16,7 +16,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Quic.Tests { - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35070")] public class QuicTransportFactoryTests : TestApplicationErrorLoggerLoggedTest { [ConditionalFact] diff --git a/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs b/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs index 8f1cd7df0d7a..33eafa1a6c33 100644 --- a/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs +++ b/src/Servers/Kestrel/Transport.Quic/test/WebHostTests.cs @@ -13,7 +13,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Quic.Tests { - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35070")] public class WebHostTests : LoggedTest { [ConditionalFact] diff --git a/src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3RequestTests.cs b/src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3RequestTests.cs index 68d8a53e0bb9..86b1dfab581d 100644 --- a/src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3RequestTests.cs +++ b/src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3RequestTests.cs @@ -22,7 +22,6 @@ namespace Interop.FunctionalTests.Http3 { - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35070")] public class Http3RequestTests : LoggedTest { private class StreamingHttpContent : HttpContent @@ -394,6 +393,7 @@ public async Task POST_ClientCancellationUpload_RequestAbortRaised(HttpProtocols [MsQuicSupported] [InlineData(HttpProtocols.Http3)] [InlineData(HttpProtocols.Http2)] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35070")] public async Task POST_ServerAbort_ClientReceivesAbort(HttpProtocols protocol) { // Arrange @@ -1472,6 +1472,7 @@ public async Task GET_ConnectionInfo_PropertiesSet() [MsQuicSupported] [InlineData(HttpProtocols.Http3)] [InlineData(HttpProtocols.Http2)] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35070")] public async Task GET_GracefulServerShutdown_AbortRequestsAfterHostTimeout(HttpProtocols protocol) { // Arrange diff --git a/src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3TlsTests.cs b/src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3TlsTests.cs index 5acb93b09680..b8fcbcc57a17 100644 --- a/src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3TlsTests.cs +++ b/src/Servers/Kestrel/test/Interop.FunctionalTests/Http3/Http3TlsTests.cs @@ -15,7 +15,6 @@ namespace Interop.FunctionalTests.Http3 { - [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35070")] public class Http3TlsTests : LoggedTest { [ConditionalFact] @@ -156,6 +155,7 @@ public async Task ClientCertificate_NoOrDelayed_Available_Ignored(ClientCertific [InlineData(ClientCertificateMode.AllowCertificate, true)] [MsQuicSupported] [OSSkipCondition(OperatingSystems.MacOSX | OperatingSystems.Linux, SkipReason = "https://github.com/dotnet/aspnetcore/issues/35800")] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35070")] public async Task ClientCertificate_AllowOrRequire_Available_Invalid_Refused(ClientCertificateMode mode, bool serverAllowInvalid) { var builder = CreateHostBuilder(async context => @@ -212,6 +212,7 @@ public async Task ClientCertificate_AllowOrRequire_Available_Invalid_Refused(Cli [ConditionalFact] [MsQuicSupported] [OSSkipCondition(OperatingSystems.MacOSX | OperatingSystems.Linux, SkipReason = "https://github.com/dotnet/aspnetcore/issues/35800")] + [QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/35070")] public async Task ClientCertificate_Allow_NotAvailable_Optional() { var builder = CreateHostBuilder(async context =>