More LoggerMessageAttribute #35368
Merged
More LoggerMessageAttribute #35368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pranavkm
commented
Aug 16, 2021
pranavkm
commented
- src/Middleware
- Some MVC projects
* src/Middleware * Some MVC projects
pranavkm
requested review from
BrennanConroy,
Tratcher and
javiercn
as code owners
adityamandaleeka
approved these changes
Aug 17, 2021
Member
adityamandaleeka
left a comment
adityamandaleeka
left a comment
There was a problem hiding this comment.
LGTM, provided that the change of IDs in PageLoggerExtensions is intentional and safe.
ghost
added this to the
Contributor
Author
|
For the Razor Pages logger ids, we think the change is fine. The current implementation re-uses IDs for similar log statements but it's not a pattern we could continue using with the source generator. Using distinct ids should be fine. I'll file a breaking change announcement for it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.