Add ProblemDetails helpers to Results #34206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Type-forward ProblemDetails to Http.Extensions * Introduce HttpValidationProblemDetails to support validation details * Remove IResult from StatusCodeResult Fixes #34169
pranavkm
requested review from
BrennanConroy,
Pilchie,
Tratcher and
javiercn
as code owners
davidfowl
reviewed
Jul 8, 2021
| /// A <see cref="ProblemDetails"/> for validation errors. | ||
| /// </summary> | ||
| [JsonConverter(typeof(HttpValidationProblemDetailsJsonConverter))] | ||
| public class HttpValidationProblemDetails : ProblemDetails |
Contributor
Author
There was a problem hiding this comment.
namespace Microsoft.AspNetCore.Mvc
{
- public class ValidationProblemDetails : ProblemDetails
+ public class ValidationProblemDetails : HttpValidationProblemDetails
{
}
}
Contributor
Author
There was a problem hiding this comment.
I'm open to not doing this - it just felt like a good way to help move the feature over to Http.Extensions.
Member
There was a problem hiding this comment.
I was originally thinking we would have ProblemDetails derive from something in the core ProblemDetailsBase.
halter73
approved these changes
Jul 9, 2021
ghost
added this to the
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34169