Added guidance about community contribution PRs #30180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `Contributing code and content` section to include information about how to choose issues to contribute to and what process to follow.
mkArtakMSFT
added
the
area-infrastructure
javiercn
reviewed
Feb 16, 2021
javiercn
reviewed
Feb 16, 2021
Co-authored-by: Javier Calvarro Nelson <[email protected]>
javiercn
approved these changes
Feb 16, 2021
Member
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
Looks great!
I hope other folks also chime in, since this is a "shared" responsibility.
Pilchie
reviewed
Feb 16, 2021
Co-authored-by: Brennan <[email protected]>
dougbu
approved these changes
Feb 17, 2021
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Likes it
Not sure if the GitHub UI is messing things up but the "Within that set," paragraph and the second item in the list are all run together and not clearly part of the same list. Might need to indent the paragraphs a bit more. (I clicked on the Display rich diff option to the left of the Viewed checkbox.)
mkArtakMSFT
commented
Feb 17, 2021
Contributor
Author
|
Thanks @dougbu. I've resolved your concern and it shows better now. |
Contributor
It does indeed 👍 |
Contributor
Author
|
@BrennanConroy, @Pilchie I'm waiting for your sign-offs. I believe I've addressed your feedback. |
BrennanConroy
approved these changes
Feb 17, 2021
Pilchie
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
Contributing code and contentsection to include information about how to choose issues to contribute to and what process to follow.This is only a part of the workflow. The next one is to make sure we ask community contributors to follow this guidance when they submit a new issue, which I will handle soon.