Quarantine tests #26062
Merged
Quarantine tests #26062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
requested review from
Tratcher,
halter73 and
jkotalik
as code owners
Tratcher
approved these changes
Sep 18, 2020
pranavkm
added
the
tell-mode
Contributor
Author
|
FYI @Pilchie |
Pilchie
reviewed
Sep 18, 2020
| <DoNotApplyWorkaroundsToMicrosoftAspNetCoreApp>true</DoNotApplyWorkaroundsToMicrosoftAspNetCoreApp> | ||
|
|
||
| <!-- Skipped due to https://github.com/dotnet/aspnetcore/issues/26061 --> | ||
| <SkipTests Condition="'$([System.Runtime.InteropServices.RuntimeInformation]::IsOSPlatform($([System.Runtime.InteropServices.OSPlatform]::OSX)))' == 'true'">true</SkipTests> |
Member
There was a problem hiding this comment.
Thanks for the FYI - lack of any coverage for dotnet watch on OSX is concerning. Let's make sure we try to investigate ASAP.
Contributor
Author
There was a problem hiding this comment.
We have a follow up to this that I think should address it: #26069. Getting this in to resolve the flakiness and I'll undo it as part of the follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.