Fix RCL template to have correct filename for scoped CSS #25870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
SteveSandersonMS
force-pushed
the
stevesa/fix-rcl-template
branch
from
4e50bf5 to
9db316a
Compare
Member
Author
|
Update: I've tracked down how this happened. Via |
mkArtakMSFT
approved these changes
Sep 14, 2020
Contributor
mkArtakMSFT
left a comment
mkArtakMSFT
left a comment
There was a problem hiding this comment.
Thanks for tracking this down, Steve!
Member
Author
|
What's the approval process for RC2 now, @mkArtakMSFT? Does @Pilchie still approve or does this need to go through tactics now? |
Member
|
I'll let this one squeak by, but from now on we'll go through Tactics. |
Member
|
Approved for .NET 5 RC2. |
Member
|
Sorry for the close/re-open :( This did pass CI before, so we could skip it this time if we wanted to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while doing some other test updates. In case you're wondering why we don't have test coverage that caught this, we actually do, here, but looks like those template baseline tests aren't running.
Description
Not sure how it happened, perhaps a bad rebase, but at some point before #25613 was merged, one of the changes in it got lost. The
wwwroot/styles.cssfile was meant to have been moved toComponent1.razor.css(and a comment in it was meant to have been removed due to it not really serving a purpose).This definitely was the case at some point as I remember verifying it. However it's clearly not there in the final PR that was merged. Update: root-cause explanation in later comment.
Customer Impact
Unless fixed, the RCL template won't use scoped CSS as clearly intended, and it will make no sense why.
Developers consuming RCLs will have to take extra steps to use them (i.e., add
<link>tags pointing to their styles).The styling in the RCL won't be scoped as intended.
Regression?
No
Risk
No. As long as the broader CSS isolation feature works correctly (which we are already counting on), then using that feature here presents no extra risk.