IJSUnmarshalledObjectReference for unmarshalled JS interop calls on JavaScript objects. Fixes #25208 #25548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackinnonBuck
force-pushed
the
t-mabuc/js-unmarshalled-object-reference
branch
from
ad7c3cf to
a575bf7
Compare
MackinnonBuck
requested review from
a team and
SteveSandersonMS
as code owners
javiercn
approved these changes
Sep 3, 2020
src/Components/WebAssembly/JSInterop/src/WebAssemblyJSRuntime.cs
Outdated
Show resolved
Hide resolved
src/JSInterop/Microsoft.JSInterop/src/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
…into t-mabuc/js-unmarshalled-object-reference
MackinnonBuck
commented
Sep 3, 2020
MackinnonBuck
commented
Sep 3, 2020
src/JSInterop/Microsoft.JSInterop/src/Implementation/JSObjectReference.cs
Show resolved
Hide resolved
src/Components/WebAssembly/WebAssembly/src/Rendering/WebAssemblyRenderer.cs
Show resolved
Hide resolved
SteveSandersonMS
approved these changes
Sep 4, 2020
Member
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
There was a problem hiding this comment.
Looks fantastic - awesome work here!
mkArtakMSFT
added
the
Servicing-consider
|
Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge. |
Contributor
|
@Pilchie can we get your approve here for RC2? |
Pilchie
added
Servicing-approved
Member
|
Approved for .NET 5 RC2. |
MackinnonBuck
changed the title
This was referenced Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
IJSUnmarshalledObjectReference, allowing high-performance JS interop calls on Blazor WebAssembly.Customer Impact
Component vendors may utilize unmarshalled JS interop calls for improved performance.
Regression?
No.
Risk
Little risk - this is an area that is well tested.
Addresses #25208