Skip to content

Quarantine UseHttpsWithAsyncCallbackDoeNotFallBackToDefaultCert #25543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2020
Merged

Quarantine UseHttpsWithAsyncCallbackDoeNotFallBackToDefaultCert #25543

merged 1 commit into from
Sep 2, 2020
+5 −1

Conversation

@halter73
Copy link
Member

@halter73 halter73 commented Sep 2, 2020

Investigation issue: #25542

Should this target release/5.0 since it's a flaky test?

@halter73 halter73 requested review from a team, BrennanConroy and jkotalik September 2, 2020 19:44
@halter73 halter73 requested a review from Tratcher as a code owner September 2, 2020 19:44
@ghost ghost added the area-servers label Sep 2, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 2, 2020

Should this target release/5.0 since it's a flaky test?

I believe @mmitche is trying to flow final bits through the system now, so we shouldn't merge there and cause a new build to spin up.

@dougbu
Copy link
Contributor

dougbu commented Sep 2, 2020

Should this target release/5.0 since it's a flaky test?

RC1 is pretty much done and dusted so I don't think even test-only changes are appropriate in release/5.0. @Pilchie and @mmitche to confirm.

@dougbu
Copy link
Contributor

dougbu commented Sep 2, 2020

😃

@ghost
Copy link

ghost commented Sep 2, 2020

Hello @halter73!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Sep 2, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-rc2 is a protected branch and I have not been granted permission to perform the merge.

1 similar comment
@ghost
Copy link

ghost commented Sep 2, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-rc2 is a protected branch and I have not been granted permission to perform the merge.

@wtgodbe wtgodbe merged commit 6ec1b48 into release/5.0-rc2 Sep 2, 2020
@wtgodbe wtgodbe deleted the halter73/25542 branch September 2, 2020 21:40
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees

No one assigned

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@halter73 @Pilchie @dougbu @BrennanConroy @amcasey @wtgodbe