-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Improving logs from hostfxr #25541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving logs from hostfxr #25541
Conversation
| // Nested block is required here because FreeLibraryAndExitThread would prevent destructors from running | ||
| // so we need to do in in a nested scope | ||
| { | ||
| // We use forwarder here instead of context->m_errorWriter itself to be able to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move the comment
| m_stringRedirectionOutput | ||
| ); | ||
|
|
||
| StandardStreamRedirection redirection(*redirectionOutput.get(), m_pHttpServer.IsCommandLineLaunch()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the StandardStreamRedirection up should be fine, it's now just called slightly earlier. No other methods modify the redirection.
ForwardingRedirectionOutput should also be fine, it still will be closed before StandardStreamRedirection.
|
@Pilchie can you merge this for rc2? |
|
Approved for .NET 5 RC2 |
Fixes #24358
Example error message: