Skip to content

Conversation

@JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Sep 2, 2020

Fixes #25353

This is a followup to #25456 to address some feedback comments.

@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Sep 2, 2020
@JunTaoLuo JunTaoLuo marked this pull request as ready for review September 3, 2020 03:23
@JunTaoLuo JunTaoLuo requested a review from a team as a code owner September 3, 2020 03:23
@JunTaoLuo JunTaoLuo added this to the 5.0.0-rc2 milestone Sep 3, 2020
@SteveSandersonMS SteveSandersonMS self-requested a review September 4, 2020 15:44
@JunTaoLuo JunTaoLuo added the Servicing-consider Shiproom approval is required for the issue label Sep 4, 2020
@ghost
Copy link

ghost commented Sep 4, 2020

Hello human! Please make sure you've included the Shiproom Template in a comment or (preferably) the PR description. Also, make sure this PR is not marked as a draft and is ready-to-merge.

@JunTaoLuo
Copy link
Contributor Author

cc @Pilchie for approval

@Pilchie
Copy link
Member

Pilchie commented Sep 4, 2020

Can @jmprieur take a look and verify that this still works as expected?

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @JunTaoLuo

@Pilchie Pilchie added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Sep 8, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 8, 2020

Thanks @jmprieur! Approved for .NET 5.0 RC2.

@JunTaoLuo JunTaoLuo merged commit 0a33267 into release/5.0-rc2 Sep 8, 2020
@JunTaoLuo JunTaoLuo deleted the johluo/simplify-blazorserver branch September 8, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants